✨ Enable SAST check in cron by default #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerschrock
force-pushed
the
enable-sast
branch
from
af99787
to
fdae45e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2223 +/- ##
=======================================
Coverage 42.35% 42.35%
=======================================
Files 95 95
Lines 7990 7990
=======================================
Hits 3384 3384
Misses 4344 4344
Partials 262 262 |
|
Integration tests success for |
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
force-pushed
the
enable-sast
branch
from
fdae45e
to
8315bad
Compare
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
|
Integration tests success for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Spencer Schrock sschrock@google.com
What kind of change does this PR introduce?
feature
What is the current behavior?
SAST is not enabled in the weekly cron
What is the new behavior (if this is a feature change)?**
SAST will run in the weekly cron
graphQL API usage will increase from 1 to 2 API calls per repo
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
This is running in the daily release test cron job and is working as intended so far. There haven't been any graphQL failures which would require us to fall back to the REST API endpoint. I'll convert this from draft PR to PR when today's test ends.
We have enough graphQL API points available (separate from the REST API limits) to absorb the increase
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)