Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix scoring issue with Code Review check #2292

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

raghavkaul
Copy link
Contributor

@raghavkaul raghavkaul commented Sep 22, 2022

What kind of change does this PR introduce?

Fix bug where number of reviewed changesets in a PR was being overcounted.

  • Tests for the changes have been added (for bug fixes/features)

Does this PR introduce a user-facing change?

NONE

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #2292 (0cc1718) into main (4693747) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 0cc1718 differs from pull request most recent head 0e93a05. Consider uploading reports for the commit 0e93a05 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
+ Coverage   41.17%   41.28%   +0.10%     
==========================================
  Files         110      110              
  Lines        8774     8773       -1     
==========================================
+ Hits         3613     3622       +9     
+ Misses       4892     4885       -7     
+ Partials      269      266       -3     

@raghavkaul raghavkaul temporarily deployed to integration-test September 27, 2022 17:53 Inactive
@github-actions
Copy link

Integration tests success for
[0cc1718]
(https://github.com/ossf/scorecard/actions/runs/3137807037)

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) September 27, 2022 21:14
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test September 27, 2022 21:14 Inactive
@github-actions
Copy link

Integration tests success for
[0e93a05]
(https://github.com/ossf/scorecard/actions/runs/3139014048)

@naveensrinivasan naveensrinivasan merged commit 01b69d2 into ossf:main Sep 27, 2022
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
Signed-off-by: Raghav Kaul <raghavkaul@google.com>

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
Signed-off-by: Raghav Kaul <raghavkaul@google.com>

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
raghavkaul added a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
Signed-off-by: Raghav Kaul <raghavkaul@google.com>

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants