📖 Clarifications about the pinned dependencies check #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2319 +/- ##
=======================================
Coverage 40.55% 40.55%
=======================================
Files 112 112
Lines 8822 8822
=======================================
Hits 3578 3578
Misses 4984 4984
Partials 260 260 |
|
Integration tests success for |
laurentsimon
approved these changes
Sep 30, 2022
katzj
force-pushed
the
pinned-deps-about-build-release-process
branch
from
9e16d59
to
24fa891
Compare
Done (note I had to explicitly remove the file and then run the command... it didn't notice the change; makefile rule looks right to me though 🤷♂️ ) |
|
Integration tests success for |
|
Integration tests success for |
The pinned dependencies check is confusing to authors of libraries, who shouldn't be pinning the dependencies of the library. But it is still valuable for flagging things which are used as part of the build and release process for a library. Signed-off-by: Jeremy Katz <jeremy@tidelift.com>
Signed-off-by: Jeremy Katz <jeremy@tidelift.com>
katzj
force-pushed
the
pinned-deps-about-build-release-process
branch
from
24fa891
to
0ffb19a
Compare
|
Integration tests success for |
azeemshaikh38
approved these changes
Oct 12, 2022
latortuga71
pushed a commit
to latortuga71/scorecard
that referenced
this pull request
Oct 27, 2022
* Clarifications about the pinned dependencies check The pinned dependencies check is confusing to authors of libraries, who shouldn't be pinning the dependencies of the library. But it is still valuable for flagging things which are used as part of the build and release process for a library. Signed-off-by: Jeremy Katz <jeremy@tidelift.com> * Regenerate docs/checks.md Signed-off-by: Jeremy Katz <jeremy@tidelift.com> Signed-off-by: Jeremy Katz <jeremy@tidelift.com> Signed-off-by: latortuga <latortugaaaa>
N8BWert
pushed a commit
to N8BWert/scorecard
that referenced
this pull request
Nov 28, 2022
* Clarifications about the pinned dependencies check The pinned dependencies check is confusing to authors of libraries, who shouldn't be pinning the dependencies of the library. But it is still valuable for flagging things which are used as part of the build and release process for a library. Signed-off-by: Jeremy Katz <jeremy@tidelift.com> * Regenerate docs/checks.md Signed-off-by: Jeremy Katz <jeremy@tidelift.com> Signed-off-by: Jeremy Katz <jeremy@tidelift.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
N8BWert
pushed a commit
to N8BWert/scorecard
that referenced
this pull request
Nov 28, 2022
* Clarifications about the pinned dependencies check The pinned dependencies check is confusing to authors of libraries, who shouldn't be pinning the dependencies of the library. But it is still valuable for flagging things which are used as part of the build and release process for a library. Signed-off-by: Jeremy Katz <jeremy@tidelift.com> * Regenerate docs/checks.md Signed-off-by: Jeremy Katz <jeremy@tidelift.com> Signed-off-by: Jeremy Katz <jeremy@tidelift.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
* Clarifications about the pinned dependencies check The pinned dependencies check is confusing to authors of libraries, who shouldn't be pinning the dependencies of the library. But it is still valuable for flagging things which are used as part of the build and release process for a library. Signed-off-by: Jeremy Katz <jeremy@tidelift.com> * Regenerate docs/checks.md Signed-off-by: Jeremy Katz <jeremy@tidelift.com> Signed-off-by: Jeremy Katz <jeremy@tidelift.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pinned dependencies check is confusing to authors of libraries, who shouldn't be pinning the dependencies of the library. But it is still valuable for flagging things which are used as part of the build and release process for a library.
Signed-off-by: Jeremy Katz jeremy@tidelift.com
What kind of change does this PR introduce?
Docs update
What is the current behavior?
Currently library maintainers are confused thinking that this check wants them to pin their dependencies but that is not the real intent. This tries to make the documentation a little clearer.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?