-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Use leveled scoring for Code Review check #2542
Conversation
* Update clients * Update scoring Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
==========================================
+ Coverage 40.03% 40.20% +0.17%
==========================================
Files 122 122
Lines 9866 9896 +30
==========================================
+ Hits 3950 3979 +29
- Misses 5635 5636 +1
Partials 281 281 |
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM. Added a few comments.
75920f9
to
44d0e02
Compare
Integration tests success for |
Integration tests success for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
Stale pull request message |
* Test coverage * Docs * Raw results Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Head branch was pushed to by a user without write access
6e1cf65
to
3c1727c
Compare
Integration tests success for |
Some unit test failures, looking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pinning the E2E test
Integration tests success for |
Integration tests success for |
* Ignore bot commits when calculating Code Review score * Update clients * Update scoring Signed-off-by: Raghav Kaul <raghavkaul@google.com> * Address PR comments * Test coverage * Docs * Raw results Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com>
* Ignore bot commits when calculating Code Review score * Update clients * Update scoring Signed-off-by: Raghav Kaul <raghavkaul@google.com> * Address PR comments * Test coverage * Docs * Raw results Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com>
What kind of change does this PR introduce?
Update the Code-Review check to better account for bot activity
Also updates Raw Results.
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Fixes #2450.
Fixes #2302.
Does this PR introduce a user-facing change?