-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add wasm files as binary artifacts #2548
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
=======================================
Coverage 40.03% 40.03%
=======================================
Files 122 122
Lines 9865 9866 +1
=======================================
+ Hits 3949 3950 +1
Misses 5635 5635
Partials 281 281 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Except for changes for projects.csv
Also, can you please include release notes in the release notes section?
Integration tests success for |
@gabibguti Please DCO the commit https://wiki.linuxfoundation.org/dco |
I updated the release-notes section |
Head branch was pushed to by a user without write access
All commits are signed-off now.
Thanks laurent! |
bd17a3a
to
b5cdfdc
Compare
b5cdfdc
to
ed69ffa
Compare
Integration tests success for |
DCO pre-submit has not started. Not sure why. |
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
This reverts commit 99fb2af. Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
ed69ffa
to
12b6ae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gabibguti!
Integration tests success for |
Integration tests success for |
* fix: Add wasm files to binary check Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> * test: Add wasm to binary check Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> * chore: Automatic projects update Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> * Revert "chore: Automatic projects update" This reverts commit 99fb2af. Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
* fix: Add wasm files to binary check Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> * test: Add wasm to binary check Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> * chore: Automatic projects update Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> * Revert "chore: Automatic projects update" This reverts commit 99fb2af. Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com> Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
WebAssembly binary files, identified by
.wasm
extension, are not considered as binaries in the Binary-Artifacts check.What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
No related issue.
Special notes for your reviewer
Retrieved
simple.wasm
test binary from https://raw.githubusercontent.com/mdn/webassembly-examples/master/js-api-examples/simple.wasm.Scorecard API identifies
.o
and.zip
as binaries but no.wasm
binaries for nodejs/node.While there are wasm binaries.
Does this PR introduce a user-facing change?
The changes may impact the users score. The remediation steps can remain the same for Binary-Artifacts. Therefore, I understand no release note is needed.