-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update name of Branch Protection Rule 📖 #2589
Conversation
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Integration tests success for |
Will this change also apply to the description given on the Remediation Steps section when you open the "Branch Protection" alert on the security tab? I've tried in a personal project, calling Scorecards with |
I think it's because the code at main does not call the scorecard at main: it still uses the latest version from Dec https://github.com/ossf/scorecard-action/blob/main/action.yaml#L56 |
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com> Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com> Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly.
Signed-off-by: Diogo Teles Sant'Anna diogoteles@google.com
What kind of change does this PR introduce?
Docs Update
Which issue(s) this PR fixes
No issue created
Special notes for your reviewer
Talked to @laurentsimon before creating this PR.
Does this PR introduce a user-facing change?
No