Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update name of Branch Protection Rule 📖 #2589

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

diogoteles08
Copy link
Contributor

On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly.

Signed-off-by: Diogo Teles Sant'Anna diogoteles@google.com

What kind of change does this PR introduce?

Docs Update

Which issue(s) this PR fixes

No issue created

Special notes for your reviewer

Talked to @laurentsimon before creating this PR.

Does this PR introduce a user-facing change?

No

NONE

On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly

Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
@diogoteles08 diogoteles08 temporarily deployed to integration-test January 10, 2023 17:51 — with GitHub Actions Inactive
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@laurentsimon laurentsimon enabled auto-merge (squash) January 10, 2023 17:53
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@naveensrinivasan naveensrinivasan changed the title Update name of Branch Protection Rule 📖 📖 Update name of Branch Protection Rule 📖 Jan 10, 2023
@github-actions
Copy link

Integration tests success for
[d7714b2]
(https://github.com/ossf/scorecard/actions/runs/3885909927)

@laurentsimon laurentsimon merged commit ed9576c into ossf:main Jan 10, 2023
@diogoteles08
Copy link
Contributor Author

Will this change also apply to the description given on the Remediation Steps section when you open the "Branch Protection" alert on the security tab?

I've tried in a personal project, calling Scorecards with ossf/scorecard-action@main, and it still pointed the branch protection rule as the old name.

@laurentsimon
Copy link
Contributor

I think it's because the code at main does not call the scorecard at main: it still uses the latest version from Dec https://github.com/ossf/scorecard-action/blob/main/action.yaml#L56

raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly

Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>

Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Apr 4, 2023
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly

Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>

Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants