🐛 Handle pinning by Docker URLs for GitHub actions workflows #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavkaul
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
spencerschrock
as code owners
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
==========================================
+ Coverage 40.40% 40.45% +0.05%
==========================================
Files 122 122
Lines 9908 9917 +9
==========================================
+ Hits 4003 4012 +9
Misses 5624 5624
Partials 281 281 |
|
Integration tests success for |
raghavkaul
force-pushed
the
bugfix-2580-gha-pinning
branch
from
5e8d3b6
to
c83f69d
Compare
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
laurentsimon
approved these changes
Jan 11, 2023
|
Thanks for the review, I'll revisit/simplify the regex and add some tests. |
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
raghavkaul
force-pushed
the
bugfix-2580-gha-pinning
branch
from
6d0ea60
to
af1504c
Compare
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
laurentsimon
approved these changes
Jan 23, 2023
laurentsimon
had a problem deploying
to
integration-test
GitHub Actions
Failure
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
spencerschrock
approved these changes
Jan 24, 2023
laurentsimon
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
raghavkaul
added a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
raghavkaul
added a commit
to raghavkaul/scorecard
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Handle Docker/other container registry URLs for GitHub actions workflows.
[jobs.<job_id>.steps[*].uses](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses)in GitHub actions can take GitHub repos, docker containers, and local filepaths. This change supports repos and containers but not local filepaths.What is the current behavior?
Only public action pinning was detected.
What is the new behavior (if this is a feature change)?**
Handle Docker image pinning. Stricter regex.
Which issue(s) this PR fixes
Fixes #2580.
Does this PR introduce a user-facing change?