Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 performance: run integration tests only on approved PRs #2609

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

Siddhant-K-code
Copy link
Contributor

What kind of change does this PR introduce?

This is a CI Performance Improvement.

What is the current behavior?

Currently, Integration tests take ~13m & every run on every PR (without approval).

What is the new behavior (if this is a feature change)?**

This Proposed changes will improve that & it would run Integration Test only on approved PRs.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #2603

Special notes for your reviewer

Does this PR introduce a user-facing change?

No

NONE

Signed-off-by: Siddhant Khare Siddhantkhare2694@gmail.com

Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com>
@github-actions
Copy link

Integration tests success for
[f89700d]
(https://github.com/ossf/scorecard/actions/runs/3975738364)

@naveensrinivasan naveensrinivasan changed the title performance: run integration tests only on approved PRs 🌱 performance: run integration tests only on approved PRs Jan 21, 2023
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) January 21, 2023 17:17
@naveensrinivasan
Copy link
Member

@Siddhant-K-code Thank you!!

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Merging #2609 (f89700d) into main (6112c07) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2609   +/-   ##
=======================================
  Coverage   40.40%   40.40%           
=======================================
  Files         122      122           
  Lines        9908     9908           
=======================================
  Hits         4003     4003           
  Misses       5624     5624           
  Partials      281      281           

@naveensrinivasan naveensrinivasan merged commit a29182d into ossf:main Jan 21, 2023
spencerschrock added a commit that referenced this pull request Jan 23, 2023
spencerschrock added a commit that referenced this pull request Jan 23, 2023
This reverts commit a29182d.

Signed-off-by: Spencer Schrock <sschrock@google.com>
naveensrinivasan pushed a commit that referenced this pull request Jan 23, 2023
This reverts commit a29182d.

Signed-off-by: Spencer Schrock <sschrock@google.com>
naveensrinivasan pushed a commit that referenced this pull request Jan 23, 2023
…2612)

This reverts commit a29182d.

Signed-off-by: Spencer Schrock <sschrock@google.com>

Signed-off-by: Spencer Schrock <sschrock@google.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com>

Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
ossf#2612)

This reverts commit a29182d.

Signed-off-by: Spencer Schrock <sschrock@google.com>

Signed-off-by: Spencer Schrock <sschrock@google.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Apr 4, 2023
Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com>

Signed-off-by: Siddhant Khare <Siddhantkhare2694@gmail.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Apr 4, 2023
ossf#2612)

This reverts commit a29182d.

Signed-off-by: Spencer Schrock <sschrock@google.com>

Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/CD rate limit improvements
2 participants