Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Azure Devops to CI checks #2662

Merged

Conversation

pettermk
Copy link

What kind of change does this PR introduce?

Adds Azure Devops as a valid CI system when running the CI check

What is the current behavior?

Repos that are tested with Azure Devops get 0 as a score, as it is not recognized

What is the new behavior (if this is a feature change)?**

Repos that are tested with Azure Devops are not penalized

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #2661

Special notes for your reviewer

I removed an entry as well, as it did not seem to possibly have any effect and also had
no tests associated

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Azure Devops is now a recognized CI system

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

checks/evaluation/ci_tests.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #2662 (8e61c4d) into main (047c014) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2662   +/-   ##
=======================================
  Coverage   41.27%   41.27%           
=======================================
  Files         123      123           
  Lines       10043    10043           
=======================================
  Hits         4145     4145           
  Misses       5602     5602           
  Partials      296      296           

@pettermk
Copy link
Author

Thanks!

Thank you, scorecard is very useful!

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Fixes ossf#2661

Signed-off-by: Petter Kvalvaag <pmkv@equinor.com>
@naveensrinivasan naveensrinivasan force-pushed the #2661-add-azure-devops-to-ci-checks branch from 4d34f95 to 8e61c4d Compare February 18, 2023 14:44
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test February 18, 2023 14:45 — with GitHub Actions Inactive
@naveensrinivasan naveensrinivasan merged commit d334409 into ossf:main Feb 18, 2023
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
Fixes ossf#2661

Signed-off-by: Petter Kvalvaag <pmkv@equinor.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
Fixes ossf#2661

Signed-off-by: Petter Kvalvaag <pmkv@equinor.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Apr 4, 2023
Fixes ossf#2661

Signed-off-by: Petter Kvalvaag <pmkv@equinor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Azure Devops as valid CI for CI Tests check
3 participants