🌱 Limit integration tests to ones that work with the GITHUB_TOKEN. #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
=======================================
Coverage 41.27% 41.27%
=======================================
Files 123 123
Lines 10043 10043
=======================================
Hits 4145 4145
Misses 5602 5602
Partials 296 296 |
naveensrinivasan
approved these changes
Feb 15, 2023
laurentsimon
approved these changes
Feb 15, 2023
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
rdower
pushed a commit
to rdower/scorecard
that referenced
this pull request
Feb 16, 2023
…f#2672) Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Robert Dower <robert.dower@intel.com>
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
…f#2672) Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
…f#2672) Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Apr 4, 2023
…f#2672) Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Integration test change
What is the current behavior?
Some of the integration tests need access to GitHub secrets, specifically the branch protection e2e tests.
What is the new behavior (if this is a feature change)?**
The integration test trigger was changed to
pull_requestwhich does not have access to GitHub secrets.The status message when integration tests finish was removed to reduce the permissions of the GITHUB_TOKEN
Which issue(s) this PR fixes
Special notes for your reviewer
This was tested in another repo to verify the GITHUB_TOKEN was sufficient.
https://github.com/spencerschrock/scorecard-test/actions/runs/4188418627/jobs/7259527613
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)