Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add new github.com/intel repos #2673

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

rdower
Copy link
Contributor

@rdower rdower commented Feb 16, 2023

What kind of change does this PR introduce?

add new projects to scorecard
(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


Signed-off-by: Robert Dower <robert.dower@intel.com>
@naveensrinivasan naveensrinivasan changed the title add new github.com/intel repos 🌱 add new github.com/intel repos Feb 16, 2023
@rdower rdower temporarily deployed to integration-test February 16, 2023 00:31 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #2673 (fb96f8b) into main (603cd92) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2673   +/-   ##
=======================================
  Coverage   41.27%   41.27%           
=======================================
  Files         123      123           
  Lines       10043    10043           
=======================================
  Hits         4145     4145           
  Misses       5602     5602           
  Partials      296      296           

@spencerschrock
Copy link
Member

Hey sorry for any confusion! It's been a while since I've ran the command, so my response in the other PR changed a few times (which may not have gotten pushed out if you use email).

The proper way to use make add-projects is:

  1. Append the new repos to the existing projects.csv
  2. Run make add-projects
  3. The changes will be made to projects.csv (projects.new.csv is a temporary file used, but gets deleted)

I see you have committed a projects.new.csv file. It should be very straight forward to fix this from the root of the repo (I've tested these commands just now):

cat cron/internal/data/projects.new.csv >> cron/internal/data/projects.csv
make add-projects

And then commit the changes to projects.csv and mark projects.new.csv as deleted (which the script shouldve done)

Signed-off-by: Robert Dower <robert.dower@intel.com>
Signed-off-by: Robert Dower <robert.dower@intel.com>
@rdower
Copy link
Contributor Author

rdower commented Feb 16, 2023

Hi Spencer,

I think I did this correctly now, and updated my PR. Thanks you for your patience and guidance.

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Sorry again for the back-and-forth.

One quick note, the weekly cron is currently paused. We are testing some changes to get it back up and running.

@spencerschrock spencerschrock temporarily deployed to integration-test February 16, 2023 18:01 — with GitHub Actions Inactive
@spencerschrock spencerschrock merged commit adb1ce3 into ossf:main Feb 16, 2023
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
* add new github.com/intel repos

Signed-off-by: Robert Dower <robert.dower@intel.com>

* removed extraneous file

Signed-off-by: Robert Dower <robert.dower@intel.com>

* add github.com/intel repos properly with dedup

Signed-off-by: Robert Dower <robert.dower@intel.com>

---------

Signed-off-by: Robert Dower <robert.dower@intel.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
* add new github.com/intel repos

Signed-off-by: Robert Dower <robert.dower@intel.com>

* removed extraneous file

Signed-off-by: Robert Dower <robert.dower@intel.com>

* add github.com/intel repos properly with dedup

Signed-off-by: Robert Dower <robert.dower@intel.com>

---------

Signed-off-by: Robert Dower <robert.dower@intel.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Apr 4, 2023
* add new github.com/intel repos

Signed-off-by: Robert Dower <robert.dower@intel.com>

* removed extraneous file

Signed-off-by: Robert Dower <robert.dower@intel.com>

* add github.com/intel repos properly with dedup

Signed-off-by: Robert Dower <robert.dower@intel.com>

---------

Signed-off-by: Robert Dower <robert.dower@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants