✨ Consider 'src/test' test directories #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
raboof
had a problem deploying
to
integration-test
GitHub Actions
Failure
naveensrinivasan
force-pushed
the
ignore-maven-project-layout-test-paths
branch
from
ab32af0
to
165bcd0
Compare
naveensrinivasan
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
==========================================
+ Coverage 41.31% 41.33% +0.01%
==========================================
Files 123 123
Lines 10039 10041 +2
==========================================
+ Hits 4148 4150 +2
Misses 5595 5595
Partials 296 296 |
auto-merge was automatically disabled
March 1, 2023 16:44
Head branch was pushed to by a user without write access
raboof
force-pushed
the
ignore-maven-project-layout-test-paths
branch
from
165bcd0
to
0ee89ea
Compare
raboof
had a problem deploying
to
integration-test
GitHub Actions
Failure
raboof
force-pushed
the
ignore-maven-project-layout-test-paths
branch
from
0ee89ea
to
a41192f
Compare
raboof
had a problem deploying
to
integration-test
GitHub Actions
Failure
|
(the |
can you rebase on main, or merge in the updates? As far as I know, the failing e2e test is due to a fuzzing e2e test which has been temporarily skipped since your branch was created |
raboof
force-pushed
the
ignore-maven-project-layout-test-paths
branch
from
a41192f
to
a9363c9
Compare
The Maven 'Standard Directory Layout' [0] is fairly widely used, not only in Maven but also in adjacent ecosystems like Gradle and clojure. Longer-term this would become part of the default policy, see discussion at ossf#1408 (comment) etc. [0]: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html Signed-off-by: Arnout Engelen <arnout@bzzt.net>
raboof
force-pushed
the
ignore-maven-project-layout-test-paths
branch
from
a9363c9
to
c2187a0
Compare
Ah, thanks, that indeed seems to have done the trick. The unit tests fail because of an intermittent error: Triggered a new build for that by force-pushing without further changes. |
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
The Maven 'Standard Directory Layout' [0] is fairly widely used, not only in Maven but also in adjacent ecosystems like Gradle and clojure. Longer-term this would become part of the default policy, see discussion at ossf#1408 (comment) etc. [0]: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html Signed-off-by: Arnout Engelen <arnout@bzzt.net> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
The Maven 'Standard Directory Layout' [0] is fairly widely used, not only in Maven but also in adjacent ecosystems like Gradle and clojure. Longer-term this would become part of the default policy, see discussion at ossf#1408 (comment) etc. [0]: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html Signed-off-by: Arnout Engelen <arnout@bzzt.net> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Enhancement: improve the quality of the default scoring
What is the current behavior?
Files in
testdatadirectories are ignored by default, but files insrc/testdirectories are not.What is the new behavior (if this is a feature change)?**
src/testis also recognized as a test directoryWhich issue(s) this PR fixes
NONE
Special notes for your reviewer
This directory is found in projects that follow the Maven Standard Directory Layout, which is fairly widely used, not only in Maven but also in adjacent ecosystems like Gradle and clojure.
Longer-term this would become part of the default policy, see discussion at #1408 (comment) etc.
Does this PR introduce a user-facing change?
For more information on release notes see: https://git.k8s.io/release/cmd/release-notes/README.md