-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Consider 'src/test' test directories #2706
✨ Consider 'src/test' test directories #2706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
ab32af0
to
165bcd0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
==========================================
+ Coverage 41.31% 41.33% +0.01%
==========================================
Files 123 123
Lines 10039 10041 +2
==========================================
+ Hits 4148 4150 +2
Misses 5595 5595
Partials 296 296 |
Head branch was pushed to by a user without write access
165bcd0
to
0ee89ea
Compare
0ee89ea
to
a41192f
Compare
(the |
can you rebase on main, or merge in the updates? As far as I know, the failing e2e test is due to a fuzzing e2e test which has been temporarily skipped since your branch was created |
a41192f
to
a9363c9
Compare
The Maven 'Standard Directory Layout' [0] is fairly widely used, not only in Maven but also in adjacent ecosystems like Gradle and clojure. Longer-term this would become part of the default policy, see discussion at ossf#1408 (comment) etc. [0]: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html Signed-off-by: Arnout Engelen <arnout@bzzt.net>
a9363c9
to
c2187a0
Compare
Ah, thanks, that indeed seems to have done the trick. The unit tests fail because of an intermittent error:
Triggered a new build for that by force-pushing without further changes. |
The Maven 'Standard Directory Layout' [0] is fairly widely used, not only in Maven but also in adjacent ecosystems like Gradle and clojure. Longer-term this would become part of the default policy, see discussion at ossf#1408 (comment) etc. [0]: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html Signed-off-by: Arnout Engelen <arnout@bzzt.net> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
The Maven 'Standard Directory Layout' [0] is fairly widely used, not only in Maven but also in adjacent ecosystems like Gradle and clojure. Longer-term this would become part of the default policy, see discussion at ossf#1408 (comment) etc. [0]: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html Signed-off-by: Arnout Engelen <arnout@bzzt.net> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
What kind of change does this PR introduce?
Enhancement: improve the quality of the default scoring
What is the current behavior?
Files in
testdata
directories are ignored by default, but files insrc/test
directories are not.What is the new behavior (if this is a feature change)?**
src/test
is also recognized as a test directoryWhich issue(s) this PR fixes
NONE
Special notes for your reviewer
This directory is found in projects that follow the Maven Standard Directory Layout, which is fairly widely used, not only in Maven but also in adjacent ecosystems like Gradle and clojure.
Longer-term this would become part of the default policy, see discussion at #1408 (comment) etc.
Does this PR introduce a user-facing change?
For more information on release notes see: https://git.k8s.io/release/cmd/release-notes/README.md