Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add projects to cronjob #2716

Merged
merged 1 commit into from
Mar 3, 2023
Merged

🌱 Add projects to cronjob #2716

merged 1 commit into from
Mar 3, 2023

Conversation

pnacht
Copy link
Contributor

@pnacht pnacht commented Mar 2, 2023

What kind of change does this PR introduce?

Adds 7 popular projects to cronjob:

  • bufbuild/protoc-gen-validate
  • rust-lang/cfg-if
  • codemirror/codemirror5
  • firebase/flutterfire
  • google/zerocopy
  • openjdk/jdk19u
  • tukaani-project/xz

Note that two of these repositories already exist in projects.csv, but with old names:

Given that the Scorecard API doesn't perform redirects from old repo names to new ones, we need to update projects occasionally. I wasn't sure whether it's best to replace them or add them as duplicates (in case someone relies on the old name). Let me know if I should replace them instead.

@pnacht pnacht temporarily deployed to integration-test March 2, 2023 22:51 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #2716 (79b29d1) into main (def5ead) will increase coverage by 41.33%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2716       +/-   ##
=========================================
+ Coverage      0   41.33%   +41.33%     
=========================================
  Files         0      123      +123     
  Lines         0    10041    +10041     
=========================================
+ Hits          0     4150     +4150     
- Misses        0     5595     +5595     
- Partials      0      296      +296     

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Given that the Scorecard API doesn't perform redirects from old repo names to new ones, we need to update projects occasionally.

This will probably need some discussion that is beyond the scope of this PR. In my opinion, what you have now works. There may be some duplicate work done, but both names will work on the scorecard side of things. Since each result is generated separately, there is a possibility for some inconsistent results between old/new name.

Adds:
- bufbuild/protoc-gen-validate
- rust-lang/cfg-if
- codemirror/codemirror5
- firebase/flutterfire
- google/zerocopy
- openjdk/jdk19u
- tukaani-project/xz

Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) March 3, 2023 18:44
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test March 3, 2023 18:45 — with GitHub Actions Inactive
@naveensrinivasan naveensrinivasan merged commit b8bc65f into ossf:main Mar 3, 2023
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
Adds:
- bufbuild/protoc-gen-validate
- rust-lang/cfg-if
- codemirror/codemirror5
- firebase/flutterfire
- google/zerocopy
- openjdk/jdk19u
- tukaani-project/xz

Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
Adds:
- bufbuild/protoc-gen-validate
- rust-lang/cfg-if
- codemirror/codemirror5
- firebase/flutterfire
- google/zerocopy
- openjdk/jdk19u
- tukaani-project/xz

Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
@pnacht pnacht deleted the new_urls branch June 12, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants