-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Initial implementation of go-git client #2720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2720 +/- ##
==========================================
- Coverage 49.91% 49.51% -0.41%
==========================================
Files 156 157 +1
Lines 11669 11795 +126
==========================================
+ Hits 5825 5840 +15
- Misses 5490 5601 +111
Partials 354 354 |
b8c5544
to
6617f93
Compare
49f0ed3
to
9c56937
Compare
spencerschrock
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for initial implementation. Some small nits
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
developer-guy
pushed a commit
to developer-guy/scorecard
that referenced
this pull request
Mar 18, 2023
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
pushed a commit
to developer-guy/scorecard
that referenced
this pull request
Mar 18, 2023
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Initial implementation of
RepoClient
APIs usinggo-git
. Note that this is not an implementation of RepoClient interface, but rather a handler to replace tarballHandler. Part of #1709.(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)