Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Updated the coverage for tests #2728

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

naveensrinivasan
Copy link
Member

  • Updated the Makefile to include the -coverpkg=./... flag when running tests.

[Makefile]

  • Changed SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out to SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out -coverpkg=./... in the Makefile

#2203

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

- Updated the `Makefile` to include the `-coverpkg=./...` flag when running tests.

[Makefile]
- Changed `SKIP_GINKGO=1 go test -race -covermode=atomic  -coverprofile=unit-coverage.out` to `SKIP_GINKGO=1 go test -race -covermode=atomic  -coverprofile=unit-coverage.out -coverpkg=./...` in the `Makefile`

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #2728 (6906f90) into main (0169c37) will increase coverage by 8.48%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
+ Coverage   41.39%   49.87%   +8.48%     
==========================================
  Files         124      156      +32     
  Lines       10164    11572    +1408     
==========================================
+ Hits         4207     5772    +1565     
+ Misses       5659     5450     -209     
- Partials      298      350      +52     

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Makefile Show resolved Hide resolved
@naveensrinivasan naveensrinivasan merged commit 0c090b3 into main Mar 7, 2023
@naveensrinivasan naveensrinivasan deleted the naveen/fix/report-coverage branch March 7, 2023 22:27
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
- Updated the `Makefile` to include the `-coverpkg=./...` flag when running tests.

[Makefile]
- Changed `SKIP_GINKGO=1 go test -race -covermode=atomic  -coverprofile=unit-coverage.out` to `SKIP_GINKGO=1 go test -race -covermode=atomic  -coverprofile=unit-coverage.out -coverpkg=./...` in the `Makefile`

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003 pushed a commit to Shofiya2003/scorecard that referenced this pull request Mar 10, 2023
- Updated the `Makefile` to include the `-coverpkg=./...` flag when running tests.

[Makefile]
- Changed `SKIP_GINKGO=1 go test -race -covermode=atomic  -coverprofile=unit-coverage.out` to `SKIP_GINKGO=1 go test -race -covermode=atomic  -coverprofile=unit-coverage.out -coverpkg=./...` in the `Makefile`

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants