Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix typo in CITests runtime errors causing duplicate Code-Review checks. #2756

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

bug fix

What is the current behavior?

Runtime errors in the CI-Tests check would return a Code-Review result due to a copy/paste typo.

What is the new behavior (if this is a feature change)?**

The typo is fixed and the function returns a CI-Tests result.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #2686 #2746

Will also help ossf/scorecard-action#1076 and ossf/scorecard-action#1094 once a new release is cut

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

The CI-Tests check will show the correct check name when it encounters a runtime error.

Signed-off-by: Spencer Schrock <sschrock@google.com>
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Unexpected explanation :/

@spencerschrock spencerschrock temporarily deployed to integration-test March 15, 2023 19:42 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #2756 (ef74ee4) into main (c20ed9e) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
+ Coverage   49.91%   50.04%   +0.12%     
==========================================
  Files         156      156              
  Lines       11669    11669              
==========================================
+ Hits         5825     5840      +15     
+ Misses       5490     5475      -15     
  Partials      354      354              

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: duplicate entries
3 participants