🌱 Commit depth for GitLab #2829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimrobison
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
jimrobison
force-pushed
the
commit-depth
branch
2 times, most recently
from
aeed049
to
6f25501
Compare
jimrobison
temporarily deployed
to
integration-test
GitHub Actions
Inactive
naveensrinivasan
removed request for
naveensrinivasan,
justaugustus,
azeemshaikh38,
spencerschrock and
laurentsimon
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2829 +/- ##
==========================================
+ Coverage 53.01% 54.67% +1.65%
==========================================
Files 161 161
Lines 12303 12332 +29
==========================================
+ Hits 6523 6742 +219
+ Misses 5404 5204 -200
- Partials 376 386 +10 |
jimrobison
force-pushed
the
commit-depth
branch
2 times, most recently
from
62f14ad
to
887626c
Compare
jimrobison
temporarily deployed
to
integration-test
GitHub Actions
Inactive
jimrobison
force-pushed
the
commit-depth
branch
from
887626c
to
52b1e97
Compare
jimrobison
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Stale pull request message |
…epth value provided Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
jimrobison
temporarily deployed
to
integration-test
GitHub Actions
Inactive
jimrobison
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Stale pull request message |
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix for #2828
What is the current behavior?
The new gitlab functionality is not using the parameter
--commit-depthin querying the gitlab repo for commits. In addition the defaulted value of 30 was not being used either, for the same reason.What is the new behavior (if this is a feature change)?**
When providing a value or using the defaults, the desired number of commits are being retrieved from gitlab repo
Which issue(s) this PR fixes
Fixes #2828
Special notes for your reviewer
Does this PR introduce a user-facing change?
No
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)