-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ show non-compliant code changes for CI-Tests, Code-Review and SAST checks in --show-details mode #2835
Conversation
… checks in --show-details mode Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
7670935
to
3ea87d4
Compare
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM. I will let @spencerschrock do a final pass and merge the PR in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Thanks for helping improve the results!
I've left 1-2 comments
Wrt. Code Review logging changes, no need to revert them - I'll rebase on top of this. |
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
@spencerschrock thanks Spencer for reviewing the PR and providing your feedback, I have addressed all of your comments in my latest PR. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
==========================================
+ Coverage 51.64% 51.73% +0.08%
==========================================
Files 158 158
Lines 12075 12109 +34
==========================================
+ Hits 6236 6264 +28
- Misses 5475 5480 +5
- Partials 364 365 +1 |
Signed-off-by: Spencer Schrock <sschrock@google.com>
…checks in --show-details mode (ossf#2835) * showing non-compliant code changes for CI-Tests, Code-Review and SAST checks in --show-details mode Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> * changing code review non-compliant revision traces to Debug from Warn Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> * changing ci test non-compliant revision trace to Debug from Warn Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> * unit test fixes in code_review_test.go Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> * Incorporating Spencer's feedback Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> --------- Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> Signed-off-by: Avishay <avishay.balter@gmail.com>
What kind of change does this PR introduce?
Fix for #2798
This change shows non-compliant code changes for CI-Tests, Code-Review and SAST checks when scorecard is run in
--show-details
mode.What is the current behavior?
These checks do not show non-compliant code changes in
Details
field when scorecard is run in--show-details
mode.What is the new behavior (if this is a feature change)?**
These shows show non-compliant Pull Requests and/or Commit SHAs in
Details
field when scorecard is run in--show-details
mode.Which issue(s) this PR fixes
Fixes #2798
Special notes for your reviewer
Does this PR introduce a user-facing change?
Yes
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)
Signed-off-by: Ashish Kurmi akurmi@stepsecurity.io