Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Reset stored error when handler is re-inited or setup is re-run. #2893

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

bug fix in the cron

What is the current behavior?

The checkruns handler never clears errSetup

What is the new behavior (if this is a feature change)?**

The checkruns handler clears errSetup when it's init'd again, or when setup is run.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #2892

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

…n agaain.

Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #2893 (fd02085) into main (ef77082) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2893      +/-   ##
==========================================
+ Coverage   51.60%   51.66%   +0.06%     
==========================================
  Files         158      158              
  Lines       12062    12064       +2     
==========================================
+ Hits         6224     6233       +9     
+ Misses       5473     5466       -7     
  Partials      365      365              

@spencerschrock spencerschrock merged commit 6c5de2c into ossf:main Apr 20, 2023
@spencerschrock spencerschrock deleted the cron/fix-sast-err branch April 20, 2023 21:28
balteravishay pushed a commit to balteravishay/scorecard that referenced this pull request May 29, 2023
…ssf#2893)

* Reset stored error when checkruns handler is re-inited or setup is run agaain.

Signed-off-by: Spencer Schrock <sschrock@google.com>

* Add test.

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Avishay <avishay.balter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAST errors in the cron aren't cleared between repos
2 participants