🐛 Reset stored error when handler is re-inited or setup is re-run. #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n agaain. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
raghavkaul
as code owners
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2893 +/- ##
==========================================
+ Coverage 51.60% 51.66% +0.06%
==========================================
Files 158 158
Lines 12062 12064 +2
==========================================
+ Hits 6224 6233 +9
+ Misses 5473 5466 -7
Partials 365 365 |
naveensrinivasan
approved these changes
Apr 20, 2023
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
May 29, 2023
…ssf#2893) * Reset stored error when checkruns handler is re-inited or setup is run agaain. Signed-off-by: Spencer Schrock <sschrock@google.com> * Add test. Signed-off-by: Spencer Schrock <sschrock@google.com> --------- Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Avishay <avishay.balter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix in the cron
What is the current behavior?
The checkruns handler never clears
errSetupWhat is the new behavior (if this is a feature change)?**
The checkruns handler clears
errSetupwhen it'sinit'd again, or whensetupis run.Which issue(s) this PR fixes
Fixes #2892
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)