-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Tweak Best Practices badge description to clarify things #2907
📖 Tweak Best Practices badge description to clarify things #2907
Conversation
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Drat, I started on a local copy of main instead of the real tip. I also didn't edit the YAML file. Give me a moment to fix that! |
This merges the current version of the main branch, then creates an updated change. Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2907 +/- ##
=======================================
Coverage 52.42% 52.42%
=======================================
Files 158 158
Lines 12108 12108
=======================================
Hits 6348 6348
Misses 5390 5390
Partials 370 370 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 1 comment, looks good otherwise.
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
* Tweak Best Practices badge description to clarify things Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com> * Provided clearer message when there's no BP badge detected Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com> * Remove extra line that shouldn't be there Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com> --------- Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com> Signed-off-by: Avishay <avishay.balter@gmail.com>
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)