📖 Tweak Best Practices badge description to clarify things #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
david-a-wheeler
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
laurentsimon
approved these changes
Apr 25, 2023
|
Drat, I started on a local copy of main instead of the real tip. I also didn't edit the YAML file. Give me a moment to fix that! |
This merges the current version of the main branch, then creates an updated change. Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
david-a-wheeler
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2907 +/- ##
=======================================
Coverage 52.42% 52.42%
=======================================
Files 158 158
Lines 12108 12108
=======================================
Hits 6348 6348
Misses 5390 5390
Partials 370 370 |
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
david-a-wheeler
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
changed the title
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
May 29, 2023
* Tweak Best Practices badge description to clarify things Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com> * Provided clearer message when there's no BP badge detected Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com> * Remove extra line that shouldn't be there Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com> --------- Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com> Signed-off-by: Avishay <avishay.balter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)