-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enable gitlab Packaging Reporting #2941
Conversation
…contents Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…file listing Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…package Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…nes containing nuget, poetry, twine publishes Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…ckaging data Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…xception Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
63e2986
to
0881a68
Compare
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
+ Coverage 53.13% 54.72% +1.58%
==========================================
Files 159 161 +2
Lines 12202 12303 +101
==========================================
+ Hits 6484 6733 +249
+ Misses 5344 5184 -160
- Partials 374 386 +12 |
@jimrobison Could you also update README.md that the Packaging check is supported? |
Are you referring to this README? It already has it annotated that it is |
Ah, gotcha. That sounds like it wasn't true before this PR (would be good to review other checks as well, I might have glossed over them). But we should be good to merge. |
* feat: Added yaml file that contains the full, flattened gitlab ci/cd contents Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated to meet linting failures Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated filename for flattened gitlab Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated to include the generated, flattened ci yaml in the file listing Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated the apiFunction to be part of the handler Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Moved packaging collection to be a repoClient specific sub-package Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * feat: Added path for gitlab projects, including a basic search for lines containing nuget, poetry, twine publishes Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Added tests for gitlab packaging finders Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Added more tests for parsing through the client and grouping packaging data Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Utilizing existing mock objects to prevent race condition exception Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Addressed linting errors Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Updated expectation for log message Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Reverted back to the original error Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> --------- Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> Co-authored-by: raghavkaul <8695110+raghavkaul@users.noreply.github.com>
* feat: Added yaml file that contains the full, flattened gitlab ci/cd contents Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated to meet linting failures Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated filename for flattened gitlab Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated to include the generated, flattened ci yaml in the file listing Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated the apiFunction to be part of the handler Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Moved packaging collection to be a repoClient specific sub-package Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * feat: Added path for gitlab projects, including a basic search for lines containing nuget, poetry, twine publishes Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Added tests for gitlab packaging finders Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Added more tests for parsing through the client and grouping packaging data Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Utilizing existing mock objects to prevent race condition exception Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Addressed linting errors Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Updated expectation for log message Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Reverted back to the original error Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> --------- Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> Co-authored-by: raghavkaul <8695110+raghavkaul@users.noreply.github.com> Signed-off-by: Avishay <avishay.balter@gmail.com>
What kind of change does this PR introduce?
Feature to accomplish initial scoring for gitlab package check.
What is the current behavior?
Packaging
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Fixes #2940
Special notes for your reviewer
docker push
nuget push
poetry publish
twine upload
Does this PR introduce a user-facing change?
Implementation of score on Packaging check for gitlab projects.
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)