✨ Enable gitlab Packaging Reporting #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimrobison
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
jimrobison
changed the title
jimrobison
changed the title
…contents Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…file listing Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…package Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…nes containing nuget, poetry, twine publishes Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…ckaging data Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
…xception Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
jimrobison
force-pushed
the
gitlab-packaging
branch
from
63e2986 to
0881a68
Compare
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
jimrobison
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com>
raghavkaul
reviewed
May 3, 2023
jimrobison
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
+ Coverage 53.13% 54.72% +1.58%
==========================================
Files 159 161 +2
Lines 12202 12303 +101
==========================================
+ Hits 6484 6733 +249
+ Misses 5344 5184 -160
- Partials 374 386 +12 |
raghavkaul
approved these changes
May 3, 2023
spencerschrock
changed the title
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
@jimrobison Could you also update README.md that the Packaging check is supported? |
Are you referring to this README? It already has it annotated that it is |
|
Ah, gotcha. That sounds like it wasn't true before this PR (would be good to review other checks as well, I might have glossed over them). But we should be good to merge. |
gabibguti
pushed a commit
to gabibguti/scorecard
that referenced
this pull request
May 10, 2023
* feat: Added yaml file that contains the full, flattened gitlab ci/cd contents Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated to meet linting failures Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated filename for flattened gitlab Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated to include the generated, flattened ci yaml in the file listing Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated the apiFunction to be part of the handler Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Moved packaging collection to be a repoClient specific sub-package Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * feat: Added path for gitlab projects, including a basic search for lines containing nuget, poetry, twine publishes Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Added tests for gitlab packaging finders Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Added more tests for parsing through the client and grouping packaging data Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Utilizing existing mock objects to prevent race condition exception Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Addressed linting errors Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Updated expectation for log message Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Reverted back to the original error Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> --------- Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> Co-authored-by: raghavkaul <8695110+raghavkaul@users.noreply.github.com>
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
May 29, 2023
* feat: Added yaml file that contains the full, flattened gitlab ci/cd contents Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated to meet linting failures Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated filename for flattened gitlab Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated to include the generated, flattened ci yaml in the file listing Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Updated the apiFunction to be part of the handler Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Moved packaging collection to be a repoClient specific sub-package Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * feat: Added path for gitlab projects, including a basic search for lines containing nuget, poetry, twine publishes Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Added tests for gitlab packaging finders Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Added more tests for parsing through the client and grouping packaging data Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Utilizing existing mock objects to prevent race condition exception Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Addressed linting errors Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * test: Updated expectation for log message Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> * refactor: Reverted back to the original error Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> --------- Signed-off-by: Robison, Jim B <jim.b.robison@lmco.com> Co-authored-by: raghavkaul <8695110+raghavkaul@users.noreply.github.com> Signed-off-by: Avishay <avishay.balter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature to accomplish initial scoring for gitlab package check.
What is the current behavior?
PackagingWhat is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Fixes #2940
Special notes for your reviewer
docker pushnuget pushpoetry publishtwine uploadDoes this PR introduce a user-facing change?
Implementation of score on Packaging check for gitlab projects.
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)