-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add packaging workflow for semantic-release #2964
Conversation
Signed-off-by: Matt Travi <programmer@travi.org>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
==========================================
+ Coverage 53.01% 53.05% +0.03%
==========================================
Files 161 161
Lines 12303 12312 +9
==========================================
+ Hits 6523 6532 +9
Misses 5404 5404
Partials 376 376 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the only blocker is the linter
Signed-off-by: Matt Travi <programmer@travi.org>
Yes, Scorecard doesn't currently follow any reusable workflows.
Thank you for the contribution! |
makes sense. thank you for confirming. would you say that there is an appetite to analyze those at some point in the future?
absolutely. thanks for accepting and for all you do on the project. i'm excited about how this will help our communities |
* ✨ Add packaging workflow for semantic-release Signed-off-by: Matt Travi <programmer@travi.org> * Resolve indentation inconsistencies Signed-off-by: Matt Travi <programmer@travi.org> --------- Signed-off-by: Matt Travi <programmer@travi.org>
* ✨ Add packaging workflow for semantic-release Signed-off-by: Matt Travi <programmer@travi.org> * Resolve indentation inconsistencies Signed-off-by: Matt Travi <programmer@travi.org> --------- Signed-off-by: Matt Travi <programmer@travi.org> Signed-off-by: Avishay <avishay.balter@gmail.com>
* ✨ Add packaging workflow for semantic-release Signed-off-by: Matt Travi <programmer@travi.org> * Resolve indentation inconsistencies Signed-off-by: Matt Travi <programmer@travi.org> --------- Signed-off-by: Matt Travi <programmer@travi.org> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
What kind of change does this PR introduce?
Adds detection for the recommended use of semantic-release in a GitHub Actions workflow.
What is the current behavior?
semantic-release
is not detected as a packaging tool. detection forpython-semantic-release
was added in #1654, but that is a separate project fromsemantic-release
What is the new behavior (if this is a feature change)?**
semantic-release
is now detected when used with npx in the workflow. the following variations are detected in therun
property of a step:npx semantic-release
npx semantic-release@21
npx semantic-release@21.0.2
npx semantic-release@beta
npx -p @semantic-release/git semantic-release
I verified that the variations above are detected when set in the testdata workflow file, but the PR currently only contains one of those variations. I did not find examples of other situations that defined multiple workflow variations for a single packaging tool detection, but I am open to feedback if additional tests would be desired.
Which issue(s) this PR fixes
Fixes #2929
Special notes for your reviewer
i personally use a reusable workflow (example reference) to capture the details of running
semantic-release
. (Since I am asemantic-release
maintainer, I mostly do this to enable easy switching from use of the latest version to a pre-release in order to test further across my own projects.) I assume reusable workflows would prevent detection of thesemantic-release
usage, is that correct or does the scanning also evaluate those?even if reusable workflows are not scanned, adding this detection would be valuable for much of our community. i would be interested to add this support and follow up with further discussion afterward about reusable workflows if not already scanned.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)