✨ New probes: code-review #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrelmbackman
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
andrelmbackman
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3302 +/- ##
==========================================
- Coverage 75.48% 68.81% -6.67%
==========================================
Files 230 232 +2
Lines 15621 15763 +142
==========================================
- Hits 11792 10848 -944
- Misses 3103 4249 +1146
+ Partials 726 666 -60 |
andrelmbackman
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Bumps [github.com/goreleaser/goreleaser](https://github.com/goreleaser/goreleaser) from 1.18.2 to 1.19.1. - [Release notes](https://github.com/goreleaser/goreleaser/releases) - [Changelog](https://github.com/goreleaser/goreleaser/blob/main/.goreleaser.yaml) - [Commits](goreleaser/goreleaser@v1.18.2...v1.19.1) --- updated-dependencies: - dependency-name: github.com/goreleaser/goreleaser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
…least found unique reviewers Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
…ogins Signed-off-by: André Backman <andre.backman@nokia.com>
…ogins Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
Signed-off-by: André Backman <andre.backman@nokia.com>
jitsengupta17
force-pushed
the
probes/code-review
branch
from
c65c111
to
4be18d6
Compare
|
@raghavkaul : i missed one //nolint:goimports . This time it should work. please review |
jitsengupta17
temporarily deployed
to
integration-test
GitHub Actions
Inactive
jitsengupta17
force-pushed
the
probes/code-review
branch
2 times, most recently
from
4be18d6
to
b89635f
Compare
|
@raghavkaul : please review i have removed the linters from probes/entries.go |
jitsengupta17
temporarily deployed
to
integration-test
GitHub Actions
Inactive
jitsengupta17
force-pushed
the
probes/code-review
branch
from
b89635f
to
5cd7bd2
Compare
|
@raghavkaul : Thanks for reviewing all previous code changes, Now added some testcase to increase the coverage please review |
jitsengupta17
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: jitsengupta17 <145664639+jitsengupta17@users.noreply.github.com>
jitsengupta17
force-pushed
the
probes/code-review
branch
from
5cd7bd2
to
4c486eb
Compare
|
@raghavkaul : Thanks for reviewing my previous code ,the error are now removed please review this changes |
jitsengupta17
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
@jitsengupta17 Would you like to give me write access to your repository/branch so I can help get this ready to merge? |
|
@raghavkaul: access right has been provided to you. please help us to merge the code. Thanks |
@raghavkaul I've sent an invite for you. After you accept the invitation you will be able to push to nokia:probes/code-review. Thanks. |
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
@raghavkaul : Thank you so much for helping us to merge the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds three probes that extends the Code-review check. The probes:
codeApproved
checks if each changeset has been approved at least once
codeReviewed
checks if each changeset has been reviewed at least once
codeReviewedTwoReviewers
checks if each changeset has been reviewed by two unique reviewers
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Fixes #3265
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)