Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fixed slack badge on README #3311

Merged
merged 1 commit into from
Jul 26, 2023
Merged

📖 Fixed slack badge on README #3311

merged 1 commit into from
Jul 26, 2023

Conversation

eddie-knight
Copy link
Contributor

What kind of change does this PR introduce?

Fixes the slack badge that is currently broken

What is the current behavior?

Screen Shot 2023-07-25 at 7 09 16 PM

What is the new behavior?

Screen Shot 2023-07-25 at 7 10 42 PM

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Let me know if style is an issue... these badges are highly customizable.

Does this PR introduce a user-facing change?

No

NONE

@eddie-knight eddie-knight temporarily deployed to gitlab July 26, 2023 00:14 — with GitHub Actions Inactive
@eddie-knight eddie-knight temporarily deployed to integration-test July 26, 2023 00:14 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #3311 (7c0bd1f) into main (81717d8) will increase coverage by 4.60%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3311      +/-   ##
==========================================
+ Coverage   61.50%   66.11%   +4.60%     
==========================================
  Files         173      173              
  Lines       12686    12686              
==========================================
+ Hits         7803     8387     +584     
+ Misses       4456     3831     -625     
- Partials      427      468      +41     

Signed-off-by: Eddie Knight <knight@linux.com>
@eddie-knight eddie-knight temporarily deployed to gitlab July 26, 2023 00:20 — with GitHub Actions Inactive
@eddie-knight eddie-knight temporarily deployed to integration-test July 26, 2023 00:20 — with GitHub Actions Inactive
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@naveensrinivasan naveensrinivasan merged commit 6b318ba into ossf:main Jul 26, 2023
@eddie-knight eddie-knight deleted the eknight/slack-badge branch July 26, 2023 14:50
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
Signed-off-by: Eddie Knight <knight@linux.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants