Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update GitHub documentation links in report #3318

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

martincostello
Copy link
Contributor

@martincostello martincostello commented Jul 26, 2023

What kind of change does this PR introduce?

  • Update Dependabot documentation links where they currently redirect.

  • Remove language code from GitHub documentation URLs in scorecard report.

  • PR title follows the guidelines defined in our pull request documentation

What is the current behavior?

English specific GitHub documentation links are shown to users in the scorecard report.

What is the new behavior (if this is a feature change)?

Language-agnostic GitHub documentation links are shown to users in the scorecard report. This then allows GitHub's documentation to redirect the user to a more appropriate language (Spanish, Japanese etc.) if relevant to the user viewing them.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

NONE

Does this PR introduce a user-facing change?

Remove links to English-specific GitHub documentation so users' language preferences are respected where possible.

- Update Dependabot documentation links.
- Remove language from GitHub documentation URLs.

Signed-off-by: martincostello <martin@martincostello.com>
@martincostello martincostello temporarily deployed to gitlab July 26, 2023 16:27 — with GitHub Actions Inactive
@martincostello martincostello temporarily deployed to integration-test July 26, 2023 16:28 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #3318 (d4be466) into main (c855ebc) will increase coverage by 4.60%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3318      +/-   ##
==========================================
+ Coverage   61.50%   66.11%   +4.60%     
==========================================
  Files         173      173              
  Lines       12686    12686              
==========================================
+ Hits         7803     8387     +584     
+ Misses       4456     3831     -625     
- Partials      427      468      +41     

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@spencerschrock spencerschrock merged commit 81ed545 into ossf:main Jul 26, 2023
@martincostello martincostello deleted the globalize-links branch July 26, 2023 19:23
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
- Update Dependabot documentation links.
- Remove language from GitHub documentation URLs.

Signed-off-by: martincostello <martin@martincostello.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants