Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add url for openfga #3337

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Conversation

aaguiarz
Copy link
Contributor

What kind of change does this PR introduce?

Add url for https://github.com/openfga/openfga repository.

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Andres Aguiar <andres.aguiar@gmail.com>
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a comma, as this is a CSV file with 2 columns.

make add-projects should help confirm once you did it correctly.

Signed-off-by: Andres Aguiar <andres.aguiar@gmail.com>
@aaguiarz
Copy link
Contributor Author

@spencerschrock thanks for the quick review!

I apologize, just fixed it and tested with make add-projects.

@aaguiarz aaguiarz temporarily deployed to gitlab July 31, 2023 22:15 — with GitHub Actions Inactive
@aaguiarz aaguiarz temporarily deployed to integration-test July 31, 2023 22:15 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3337 (0fe8858) into main (1819192) will decrease coverage by 11.72%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3337       +/-   ##
===========================================
- Coverage   73.26%   61.54%   -11.72%     
===========================================
  Files         173      173               
  Lines       12717    12717               
===========================================
- Hits         9317     7827     -1490     
- Misses       2877     4463     +1586     
+ Partials      523      427       -96     

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@spencerschrock spencerschrock merged commit c8a7abd into ossf:main Jul 31, 2023
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
* Add https://github/openfga/openfga repository

Signed-off-by: Andres Aguiar <andres.aguiar@gmail.com>

* Added missing comma

Signed-off-by: Andres Aguiar <andres.aguiar@gmail.com>

---------

Signed-off-by: Andres Aguiar <andres.aguiar@gmail.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants