Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ GitLab: Release #3340

Merged
merged 5 commits into from
Aug 4, 2023
Merged

✨ GitLab: Release #3340

merged 5 commits into from
Aug 4, 2023

Conversation

raghavkaul
Copy link
Contributor

What kind of change does this PR introduce?

Add documentation and remove SCORECARD_EXPERIMENTAL flag for GitLab client.

Release note

* GitLab: GitLab support is moved out of experimental.

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
@raghavkaul raghavkaul temporarily deployed to gitlab August 2, 2023 20:04 — with GitHub Actions Inactive
@raghavkaul raghavkaul temporarily deployed to integration-test August 2, 2023 20:05 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #3340 (f0adde7) into main (76dc144) will decrease coverage by 6.34%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
- Coverage   73.74%   67.41%   -6.34%     
==========================================
  Files         178      178              
  Lines       12864    12862       -2     
==========================================
- Hits         9487     8671     -816     
- Misses       2835     3682     +847     
+ Partials      542      509      -33     

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
@raghavkaul raghavkaul temporarily deployed to gitlab August 2, 2023 20:24 — with GitHub Actions Inactive
@raghavkaul raghavkaul temporarily deployed to integration-test August 2, 2023 20:24 — with GitHub Actions Inactive
@spencerschrock
Copy link
Member

Just an FYI, should update the GitLab example pipeline after this gets merged

As it still has the SCORECARD_EXPERIMENTAL flag.

    - docker run -e SCORECARD_EXPERIMENTAL=1 -e GITLAB_AUTH_TOKEN=$GITLAB_AUTH_TOKEN gcr.io/openssf/scorecard:stable --repo $CI_PROJECT_URL

@raghavkaul raghavkaul temporarily deployed to gitlab August 4, 2023 16:27 — with GitHub Actions Inactive
@raghavkaul raghavkaul temporarily deployed to integration-test August 4, 2023 16:27 — with GitHub Actions Inactive
@raghavkaul raghavkaul temporarily deployed to gitlab August 4, 2023 18:01 — with GitHub Actions Inactive
@raghavkaul raghavkaul temporarily deployed to integration-test August 4, 2023 18:01 — with GitHub Actions Inactive
@raghavkaul raghavkaul merged commit 7ed886f into ossf:main Aug 4, 2023
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
* Remove experimental flag

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

* Docs

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

* update tests

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

---------

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants