Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Ignore missing tarballs for empty org .github repos #3433

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

spencerschrock
Copy link
Member

@spencerschrock spencerschrock commented Aug 28, 2023

What kind of change does this PR introduce?

bug fix

What is the current behavior?

If the Security-Policy check is run for a repo owned by an org with an empty .github repo, it runs a warning.

What is the new behavior (if this is a feature change)?**

the error doesn't print if the repo being looked at is .github

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #3076

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

The Security-Policy check will no longer print to the log if the org's .github repo is empty.

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock temporarily deployed to gitlab August 28, 2023 19:33 — with GitHub Actions Inactive
@spencerschrock spencerschrock temporarily deployed to integration-test August 28, 2023 19:33 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #3433 (a1f21f9) into main (b0a96fe) will decrease coverage by 6.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3433      +/-   ##
==========================================
- Coverage   72.81%   66.80%   -6.02%     
==========================================
  Files         185      185              
  Lines       13145    13150       +5     
==========================================
- Hits         9572     8785     -787     
- Misses       3050     3875     +825     
+ Partials      523      490      -33     

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock temporarily deployed to gitlab August 28, 2023 21:31 — with GitHub Actions Inactive
@spencerschrock spencerschrock temporarily deployed to integration-test August 28, 2023 21:31 — with GitHub Actions Inactive
Copy link
Contributor

@raghavkaul raghavkaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@spencerschrock spencerschrock merged commit b69b69f into ossf:main Aug 28, 2023
40 of 41 checks passed
@spencerschrock spencerschrock deleted the silence-empty-org-tarball branch August 28, 2023 21:46
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
* Ignore tarball errors on org's .github folder

Signed-off-by: Spencer Schrock <sschrock@google.com>

* add test.

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Security-Policy throws a warning if target repo's org has an empty .github repo
2 participants