-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update bestpractices links #3448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
For myself and others, here's some context: coreinfrastructure/best-practices-badge#2043
@fredgan can you please DCO the commit? These instructions come from the
|
79c15a8
to
9b36352
Compare
LGTM DCO Bot is still complaining about a missing whitespace in the signoff name: |
Signed-off-by: Fred Gan <ganshaolong@vip.qq.com>
9b36352
to
f7b793e
Compare
Fixed, thanks @spencerschrock @gabibguti |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3448 +/- ##
==========================================
- Coverage 72.80% 64.27% -8.53%
==========================================
Files 186 186
Lines 13155 13155
==========================================
- Hits 9577 8455 -1122
- Misses 3059 4237 +1178
+ Partials 519 463 -56 |
Signed-off-by: Fred Gan <ganshaolong@vip.qq.com> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
What kind of change does this PR introduce?
Update BestPractices links where they currently redirect.
What is the current behavior?
Old domain name
bestpractices.coreinfrastructure.org
are used in the BestPractices.What is the new behavior (if this is a feature change)?**
New domain name
www.bestpractices.dev
are used in the BestPractices.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
NONE
Does this PR introduce a user-facing change?