Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update bestpractices links #3448

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

fredgan
Copy link
Contributor

@fredgan fredgan commented Sep 4, 2023

What kind of change does this PR introduce?

Update BestPractices links where they currently redirect.

What is the current behavior?

Old domain name bestpractices.coreinfrastructure.org are used in the BestPractices.

What is the new behavior (if this is a feature change)?**

New domain name www.bestpractices.dev are used in the BestPractices.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

NONE

Does this PR introduce a user-facing change?

Update new domain name of Best Practices.

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

For myself and others, here's some context: coreinfrastructure/best-practices-badge#2043

@spencerschrock
Copy link
Member

@fredgan can you please DCO the commit? These instructions come from the Details link of the DCO check/status.

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin fix_bestpractices_links

@gabibguti
Copy link
Contributor

LGTM

DCO Bot is still complaining about a missing whitespace in the signoff name:
Expected "Fred Gan ganshaolong@vip.qq.com", but got "FredGan ganshaolong@vip.qq.com".
Did you use the git rebase HEAD~1 --signoff command?

Signed-off-by: Fred Gan <ganshaolong@vip.qq.com>
@fredgan
Copy link
Contributor Author

fredgan commented Sep 11, 2023

Fixed, thanks @spencerschrock @gabibguti

@spencerschrock spencerschrock temporarily deployed to gitlab September 12, 2023 22:34 — with GitHub Actions Inactive
@spencerschrock spencerschrock temporarily deployed to integration-test September 12, 2023 22:34 — with GitHub Actions Inactive
@spencerschrock spencerschrock enabled auto-merge (squash) September 12, 2023 22:38
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #3448 (a20fbab) into main (ac6ea11) will decrease coverage by 8.53%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3448      +/-   ##
==========================================
- Coverage   72.80%   64.27%   -8.53%     
==========================================
  Files         186      186              
  Lines       13155    13155              
==========================================
- Hits         9577     8455    -1122     
- Misses       3059     4237    +1178     
+ Partials      519      463      -56     

@spencerschrock spencerschrock merged commit 146f0eb into ossf:main Sep 12, 2023
37 of 38 checks passed
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
Signed-off-by: Fred Gan <ganshaolong@vip.qq.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants