Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Check for static archives in Binary Artifacts #3454

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

DavidKorczynski
Copy link
Contributor

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

Static archives do not lead to score reduction in Binary Artifacts, although .o files do and .a correspond to a group of .o files.

What is the new behavior (if this is a feature change)?**

Static archives lead to score reduction.

  • Tests for the changes have been added (for bug fixes/features)

Did not add a test because only a few binary checks have these. It may also be in the interest of size for the repository not to have .a files stored?

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

None

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Add static archives as binary artifacts

Signed-off-by: David Korczynski <david@adalogics.com>
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #3454 (70a7746) into main (3af46eb) will decrease coverage by 6.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3454      +/-   ##
==========================================
- Coverage   72.87%   66.81%   -6.06%     
==========================================
  Files         185      185              
  Lines       13148    13149       +1     
==========================================
- Hits         9582     8786     -796     
- Misses       3044     3873     +829     
+ Partials      522      490      -32     

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@DavidKorczynski DavidKorczynski temporarily deployed to integration-test September 5, 2023 15:47 — with GitHub Actions Inactive
@spencerschrock spencerschrock merged commit 7386b65 into ossf:main Sep 5, 2023
40 of 41 checks passed
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants