🌱 convert vulnerabilities check to probe #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
AdamKorcz
force-pushed
the
vulnerabilities-probe
branch
from
8748930
to
bcc7d62
Compare
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3487 +/- ##
===========================================
- Coverage 76.12% 63.48% -12.65%
===========================================
Files 198 187 -11
Lines 13700 12914 -786
===========================================
- Hits 10429 8198 -2231
- Misses 2663 4198 +1535
+ Partials 608 518 -90 |
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
|
@laurentsimon @spencerschrock PTAL again. |
AdamKorcz
force-pushed
the
vulnerabilities-probe
branch
from
55cd468
to
f86b51e
Compare
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
AdamKorcz
force-pushed
the
vulnerabilities-probe
branch
from
6745b35
to
f75ff38
Compare
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
AdamKorcz
force-pushed
the
vulnerabilities-probe
branch
from
23e051f
to
e9688ee
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
approved these changes
Oct 24, 2023
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
AdamKorcz
force-pushed
the
vulnerabilities-probe
branch
from
e9688ee
to
eeced8d
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: AdamKorcz <adam@adalogics.com>
AdamKorcz
force-pushed
the
vulnerabilities-probe
branch
from
67d44ff
to
e0ff285
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
| f = f.WithMessage(fmt.Sprintf("Project is vulnerable to: %s", | ||
| strings.Join(vuln.IDs, " / "))) | ||
| f = f.WithRemediationMetadata(map[string]string{ | ||
| "osvid": strings.Join(vuln.IDs[:], ","), |
There was a problem hiding this comment.
are there multiple IDs returned for each vulnerability? Will the URL work properly?
There was a problem hiding this comment.
There can be, depending on if there are aliases, in which case we'd want to grab just one.
There was a problem hiding this comment.
Let's fix in a follow-up PR then. Created #3609 for tracking
diogoteles08
pushed a commit
to diogoteles08/scorecard
that referenced
this pull request
Nov 13, 2023
* 🌱 convert vulnerabilities check to probe Signed-off-by: AdamKorcz <adam@adalogics.com> * rename probe + nits Signed-off-by: AdamKorcz <adam@adalogics.com> * edit def.yml Signed-off-by: AdamKorcz <adam@adalogics.com> * Add vuln ID dynamically to def.yml Signed-off-by: AdamKorcz <adam@adalogics.com> * Elaborate the purpose of test data in unit test Signed-off-by: AdamKorcz <adam@adalogics.com> * Move logging out of loop and change logic of negativeFindings() Signed-off-by: AdamKorcz <adam@adalogics.com> * preserve number of vulns found in output Signed-off-by: AdamKorcz <adam@adalogics.com> * Preserve grouping of vulns Signed-off-by: AdamKorcz <adam@adalogics.com> * fix linter issues Signed-off-by: AdamKorcz <adam@adalogics.com> * Add remediation data Signed-off-by: AdamKorcz <adam@adalogics.com> * use checker.LogFindings() Signed-off-by: AdamKorcz <adam@adalogics.com> --------- Signed-off-by: AdamKorcz <adam@adalogics.com> Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* 🌱 convert vulnerabilities check to probe Signed-off-by: AdamKorcz <adam@adalogics.com> * rename probe + nits Signed-off-by: AdamKorcz <adam@adalogics.com> * edit def.yml Signed-off-by: AdamKorcz <adam@adalogics.com> * Add vuln ID dynamically to def.yml Signed-off-by: AdamKorcz <adam@adalogics.com> * Elaborate the purpose of test data in unit test Signed-off-by: AdamKorcz <adam@adalogics.com> * Move logging out of loop and change logic of negativeFindings() Signed-off-by: AdamKorcz <adam@adalogics.com> * preserve number of vulns found in output Signed-off-by: AdamKorcz <adam@adalogics.com> * Preserve grouping of vulns Signed-off-by: AdamKorcz <adam@adalogics.com> * fix linter issues Signed-off-by: AdamKorcz <adam@adalogics.com> * Add remediation data Signed-off-by: AdamKorcz <adam@adalogics.com> * use checker.LogFindings() Signed-off-by: AdamKorcz <adam@adalogics.com> --------- Signed-off-by: AdamKorcz <adam@adalogics.com> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Migration of Vulnerabilities check to probe.
PR title follows the guidelines defined in our pull request documentation
Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
No