Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Pinned-Dependencies continues on error #3515

Merged
merged 21 commits into from
Nov 8, 2023
Merged

🐛 Pinned-Dependencies continues on error #3515

merged 21 commits into from
Nov 8, 2023

Commits on Nov 6, 2023

  1. Continue on error detecting OS 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d98cff8 View commit details
    Browse the repository at this point in the history

  2. Add tests for error detecting OS 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    2282d62 View commit details
    Browse the repository at this point in the history

  3. Add ElementError to identify elements that errored 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d70fe00 View commit details
    Browse the repository at this point in the history

  4. Add Incomplete field to PinningDependenciesData 

    Will store all errors handled during analysis, which may lead to incomplete results.

Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    4cb3b29 View commit details
    Browse the repository at this point in the history

  5. Register job steps that errored out 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    43481dc View commit details
    Browse the repository at this point in the history

  6. Add tests that incomplete steps are caught 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8231381 View commit details
    Browse the repository at this point in the history

  7. Add warnings to details about incomplete steps 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a008a16 View commit details
    Browse the repository at this point in the history

  8. Add tests that incomplete steps generate warnings 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    9ec3fac View commit details
    Browse the repository at this point in the history

  9. Register shell files skipped due to parser errors 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a605690 View commit details
    Browse the repository at this point in the history

  10. Add tests showing when parser errors affect analysis 

    Dockerfile pinning is not affected.
Everything in a 'broken' Dockerfile RUN block is ignored
Everything in a 'broken' shell script is ignored
testdata/script-invalid.sh modified to demonstrate the above

Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    7955c8a View commit details
    Browse the repository at this point in the history

  11. Incomplete results logged as Info, not Warn 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    aa4bae7 View commit details
    Browse the repository at this point in the history

  12. Remove Type from logging of incomplete results 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    2b9e3d2 View commit details
    Browse the repository at this point in the history

  13. Update tests after rebase 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    37d0c34 View commit details
    Browse the repository at this point in the history

  14. Add Unwrap for ElementError, improve its docs 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    4701708 View commit details
    Browse the repository at this point in the history

  15. Add ElementError case to evaluation unit test 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f6768ff View commit details
    Browse the repository at this point in the history

  16. Move ElementError to checker/raw_result 

    checker/raw_result defines types used to describe analysis results.

ElementError is meant to describe potential flaws in the analysis
and is therefore a sort of analysis result itself.

Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    de292f2 View commit details
    Browse the repository at this point in the history

  17. Use finding.Location for ElementError.Element 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    970a7f1 View commit details
    Browse the repository at this point in the history

  18. Use an ElementError for script parser errors 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    01f3fe2 View commit details
    Browse the repository at this point in the history

  19. Replace .Incomplete []error with .ProcessingErrors []ElementError 

    Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    74f9892 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Adopt from reviewer comments 

    - Replace ElementError's `Element *finding.Location`
  with `Location finding.Location`
- Rename ErrorJobOSParsing to ErrJobOSParsing to satisfy linter
- Fix unit test

Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
    @pnacht
    pnacht committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f388437 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pinned-deps-continue-on-error

    @spencerschrock
    spencerschrock committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5705652 View commit details
    Browse the repository at this point in the history