-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Pinned-Dependencies continues on error #3515
🐛 Pinned-Dependencies continues on error #3515
Commits on Nov 6, 2023
-
Continue on error detecting OS
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for d98cff8 - Browse repository at this point
Copy the full SHA d98cff8View commit details -
Add tests for error detecting OS
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 2282d62 - Browse repository at this point
Copy the full SHA 2282d62View commit details -
Add ElementError to identify elements that errored
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for d70fe00 - Browse repository at this point
Copy the full SHA d70fe00View commit details -
Add Incomplete field to PinningDependenciesData
Will store all errors handled during analysis, which may lead to incomplete results. Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 4cb3b29 - Browse repository at this point
Copy the full SHA 4cb3b29View commit details -
Register job steps that errored out
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 43481dc - Browse repository at this point
Copy the full SHA 43481dcView commit details -
Add tests that incomplete steps are caught
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 8231381 - Browse repository at this point
Copy the full SHA 8231381View commit details -
Add warnings to details about incomplete steps
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for a008a16 - Browse repository at this point
Copy the full SHA a008a16View commit details -
Add tests that incomplete steps generate warnings
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 9ec3fac - Browse repository at this point
Copy the full SHA 9ec3facView commit details -
Register shell files skipped due to parser errors
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for a605690 - Browse repository at this point
Copy the full SHA a605690View commit details -
Add tests showing when parser errors affect analysis
Dockerfile pinning is not affected. Everything in a 'broken' Dockerfile RUN block is ignored Everything in a 'broken' shell script is ignored testdata/script-invalid.sh modified to demonstrate the above Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 7955c8a - Browse repository at this point
Copy the full SHA 7955c8aView commit details -
Incomplete results logged as Info, not Warn
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for aa4bae7 - Browse repository at this point
Copy the full SHA aa4bae7View commit details -
Remove
Type
from logging of incomplete resultsSigned-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 2b9e3d2 - Browse repository at this point
Copy the full SHA 2b9e3d2View commit details -
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 37d0c34 - Browse repository at this point
Copy the full SHA 37d0c34View commit details -
Add Unwrap for ElementError, improve its docs
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 4701708 - Browse repository at this point
Copy the full SHA 4701708View commit details -
Add ElementError case to evaluation unit test
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for f6768ff - Browse repository at this point
Copy the full SHA f6768ffView commit details -
Move ElementError to checker/raw_result
checker/raw_result defines types used to describe analysis results. ElementError is meant to describe potential flaws in the analysis and is therefore a sort of analysis result itself. Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for de292f2 - Browse repository at this point
Copy the full SHA de292f2View commit details -
Use finding.Location for ElementError.Element
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 970a7f1 - Browse repository at this point
Copy the full SHA 970a7f1View commit details -
Use an ElementError for script parser errors
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 01f3fe2 - Browse repository at this point
Copy the full SHA 01f3fe2View commit details -
Replace .Incomplete []error with .ProcessingErrors []ElementError
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for 74f9892 - Browse repository at this point
Copy the full SHA 74f9892View commit details
Commits on Nov 8, 2023
-
- Replace ElementError's `Element *finding.Location` with `Location finding.Location` - Rename ErrorJobOSParsing to ErrJobOSParsing to satisfy linter - Fix unit test Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Configuration menu - View commit details
-
Copy full SHA for f388437 - Browse repository at this point
Copy the full SHA f388437View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5705652 - Browse repository at this point
Copy the full SHA 5705652View commit details