Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove sonatype lift as a recognized dep update tool #3605

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

bug fix

What is the current behavior?

The Dependency-Update-Tool recognizes and recommends Sonatype Lift.

What is the new behavior (if this is a feature change)?**

Sonatype Lift detection, raw data, probes etc are removed.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #3559

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Sonatype Lift is no longer recognized as a Dependency-Update-Tool because it is retired.

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock temporarily deployed to gitlab October 24, 2023 22:39 — with GitHub Actions Inactive
@spencerschrock spencerschrock temporarily deployed to integration-test October 24, 2023 22:39 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #3605 (7475206) into main (5f171ba) will decrease coverage by 6.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3605      +/-   ##
==========================================
- Coverage   76.18%   70.18%   -6.00%     
==========================================
  Files         199      198       -1     
  Lines       13733    13700      -33     
==========================================
- Hits        10462     9616     -846     
- Misses       2663     3525     +862     
+ Partials      608      559      -49     

@justaugustus justaugustus merged commit f2bbd0a into ossf:main Oct 25, 2023
41 checks passed
@spencerschrock spencerschrock deleted the dut/remove-sonatype-lift branch October 25, 2023 16:48
diogoteles08 pushed a commit to diogoteles08/scorecard that referenced this pull request Nov 13, 2023
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
ashearin pushed a commit to kgangerlm/scorecard-gitlab that referenced this pull request Nov 13, 2023
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Remove Sonatype Lift from Dependency-Update-Tool check
3 participants