馃摉 Added beginner's guide to scorecard checks docs #3617
Conversation
There was a problem hiding this comment.
Thank you for this fantastic guide, @ariathaker! Left some comments for clarity / tone, but overall LGTM --- this will be a great resource for maintainers new to this area.
|
This pull request is stale because it has been open for 10 days with no activity |
|
Thanks for the updates, @ariathaker! It looks like you'll need to sign a DCO to get this merged. @spencerschrock What're the next steps for review here? |
-Edited README to link to the beginner's guide Signed-off-by: ariathaker <ariathaker@gmail.com>
Incorporating Spencer's edits. Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
ariathaker
force-pushed
the
beginnerchecks
branch
from
5c3417c
to
b4d30eb
Compare
|
Ah, thanks @olivekl! I just rebased to include the signature. |
I'll take a look again tomorrow 馃憖. |
|
You should also change the PR from draft to "ready for review" (I can also hit this button, but as a maintainer it helps know when the author thinks the PR is ready for review) |
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com>
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com>
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com>
It's happened to me before too. In my experience, it depends on which screen you use to leave the comments. |
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com>
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3617 +/- ##
==========================================
- Coverage 76.31% 68.63% -7.68%
==========================================
Files 210 210
Lines 14371 14371
==========================================
- Hits 10967 9864 -1103
- Misses 2757 3934 +1177
+ Partials 647 573 -74 |
-Also edited README to link to the beginner's guide
What kind of change does this PR introduce?
Docs update
What is the current behavior?
N/A
What is the new behavior (if this is a feature change)?**
N/A
Which issue(s) this PR fixes
Addresses issue #3434 --Docs addition: getting started guide.
Special notes for your reviewer
N/A
Does this PR introduce a user-facing change?