-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Added beginner's guide to scorecard checks docs #3617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fantastic guide, @ariathaker! Left some comments for clarity / tone, but overall LGTM --- this will be a great resource for maintainers new to this area.
This pull request is stale because it has been open for 10 days with no activity |
Thanks for the updates, @ariathaker! It looks like you'll need to sign a DCO to get this merged. @spencerschrock What're the next steps for review here? |
-Edited README to link to the beginner's guide Signed-off-by: ariathaker <ariathaker@gmail.com>
Incorporating Spencer's edits. Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com> Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com> Signed-off-by: ariathaker <ariathaker@gmail.com>
5c3417c
to
b4d30eb
Compare
Ah, thanks @olivekl! I just rebased to include the signature. |
I'll take a look again tomorrow 👀. |
You should also change the PR from draft to "ready for review" (I can also hit this button, but as a maintainer it helps know when the author thinks the PR is ready for review) |
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com>
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very sorry, I didn't realize the "Pending" badge meant that my comments and changes weren't visible! Submitting them all now
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com>
It's happened to me before too. In my experience, it depends on which screen you use to leave the comments. |
Signed-off-by: ariathaker <51683211+ariathaker@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3617 +/- ##
==========================================
- Coverage 76.31% 68.63% -7.68%
==========================================
Files 210 210
Lines 14371 14371
==========================================
- Hits 10967 9864 -1103
- Misses 2757 3934 +1177
+ Partials 647 573 -74 |
-Also edited README to link to the beginner's guide
What kind of change does this PR introduce?
Docs update
What is the current behavior?
N/A
What is the new behavior (if this is a feature change)?**
N/A
Which issue(s) this PR fixes
Addresses issue #3434 --Docs addition: getting started guide.
Special notes for your reviewer
N/A
Does this PR introduce a user-facing change?