✨ Add WithValues function to findings #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
requested review from
azeemshaikh38,
justaugustus,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
laurentsimon
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3619 +/- ##
==========================================
- Coverage 76.11% 70.22% -5.89%
==========================================
Files 199 199
Lines 13738 13741 +3
==========================================
- Hits 10456 9649 -807
- Misses 2671 3532 +861
+ Partials 611 560 -51 |
Signed-off-by: laurentsimon <laurentsimon@google.com>
laurentsimon
temporarily deployed
to
integration-test
GitHub Actions
Inactive
laurentsimon
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
changed the title
spencerschrock
approved these changes
Oct 27, 2023
Abeanna
approved these changes
Oct 29, 2023
diogoteles08
pushed a commit
to diogoteles08/scorecard
that referenced
this pull request
Nov 13, 2023
* update Signed-off-by: laurentsimon <laurentsimon@google.com> * update comment Signed-off-by: laurentsimon <laurentsimon@google.com> * typo Signed-off-by: laurentsimon <laurentsimon@google.com> --------- Signed-off-by: laurentsimon <laurentsimon@google.com> Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* update Signed-off-by: laurentsimon <laurentsimon@google.com> * update comment Signed-off-by: laurentsimon <laurentsimon@google.com> * typo Signed-off-by: laurentsimon <laurentsimon@google.com> --------- Signed-off-by: laurentsimon <laurentsimon@google.com> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Add WithValues function to findings to simplify the creation of probes findings.
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)