🌱 bump project minimum Go version to go1.21 #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
possibly spin this off into its own PR Signed-off-by: Spencer Schrock <sschrock@google.com>
As of Go 1.20, the generator is seeded randomly at startup. https://pkg.go.dev/math/rand#Seed Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
justaugustus and
laurentsimon
and removed request for
a team
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3661 +/- ##
==========================================
- Coverage 76.06% 70.44% -5.63%
==========================================
Files 206 206
Lines 14065 14060 -5
==========================================
- Hits 10699 9905 -794
- Misses 2733 3578 +845
+ Partials 633 577 -56 |
laurentsimon
approved these changes
Nov 13, 2023
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
go version bump + minor cleanup
What is the current behavior?
go 1.19 is the minimum version required for anyone looking to compile/import Scorecard.
note: our tooling/docker already uses go1.21 for our toolchain
What is the new behavior (if this is a feature change)?**
go 1.21 is the minimum version to add Scorecard as a dependency. This lets us make some refactoring changes:
maxandminbuiltins (https://go.dev/doc/go1.21) and get rid of our other workaroundsslicespackage is part of the stdlib now, not just an experimental package (https://go.dev/doc/go1.21#slices)Which issue(s) this PR fixes
Part of #3418, but doesn't entirely fix it. The
sync. OnceValuesstuff will be a larger change so I didn't include it here.Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)