🌱 refactor pinned dependencies #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
requested review from
raghavkaul and
laurentsimon
and removed request for
a team
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3667 +/- ##
==========================================
- Coverage 76.23% 70.76% -5.47%
==========================================
Files 209 209
Lines 14212 14310 +98
==========================================
- Hits 10834 10127 -707
- Misses 2737 3596 +859
+ Partials 641 587 -54 |
AdamKorcz
force-pushed
the
pinned-dependencies-2
branch
from
24a6469
to
029c930
Compare
AdamKorcz
had a problem deploying
to
integration-test
GitHub Actions
Failure
AdamKorcz
force-pushed
the
pinned-dependencies-2
branch
from
029c930
to
f04e177
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
AdamKorcz
force-pushed
the
pinned-dependencies-2
branch
from
f04e177
to
e79c177
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
/scdiff generate Pinned-Dependencies |
spencerschrock
approved these changes
Nov 20, 2023
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
AdamKorcz
force-pushed
the
pinned-dependencies-2
branch
from
e79c177
to
4d7886c
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The goal of this PR is to refactor the Pinned Dependencies evaluation to process findings instead of dependencies. The reason for doing this is to structure the code to resemble how it would look once it gets split into probes without modifying the score. As such, this is an intermediary code change towards migrating the Pinned Dependencies check into probes. Some of the code changes in this PR will be moved into probes in the near future.
My motivation for this PR is to reduce the review overhead. This PR is already substantial, and adding probes would add to that. As such, with this PR I want to refactor the code so it works as-is and make incremental steps towards migrating the check to probes.
The core change of this PR is an added step of converting the dependencies to findings and calculate the score + log from the findings instead of directly from the dependencies. Other code changes are utilities and tests around that core change.
(Is it a bug fix, feature, docs update, something else?)
PR title follows the guidelines defined in our pull request documentation
Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
NONE
Does this PR introduce a user-facing change?
NONE