🌱 update GitLab CI-Tests e2e to reflect 30 commits
#3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14f864b not only fixed the --commit-depth option, but also fixed the default commit depth for GitLab repos. Previously GitLab repos looked back 20 commits because that was GitLab's default for the commits API. Now, GitLab repos look back 30 commits, so the proportions of this e2e test changed. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
raghavkaul and
laurentsimon
and removed request for
a team
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3676 +/- ##
==========================================
- Coverage 74.98% 68.10% -6.88%
==========================================
Files 205 205
Lines 14042 14042
==========================================
- Hits 10529 9564 -965
- Misses 2906 3930 +1024
+ Partials 607 548 -59 |
raghavkaul
approved these changes
Nov 15, 2023
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up test fix from #3672, which not only fixed the --commit-depth option, but also fixed the default commit depth for GitLab repos. Previously GitLab repos looked back 20 commits because that was GitLab's default for the commits API. Now, GitLab repos look back 30 commits, so the proportions of this e2e test changed.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
the test was written when 20 commits were analyzed, but #3672 made it so 30 commits are analyzed
What is the new behavior (if this is a feature change)?**
e2e test values reflect 30 commits
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)