🐛 handle gitlab repos with no commits #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3731 +/- ##
==========================================
- Coverage 75.93% 70.91% -5.03%
==========================================
Files 229 229
Lines 15377 15380 +3
==========================================
- Hits 11677 10907 -770
- Misses 2978 3805 +827
+ Partials 722 668 -54 |
|
Is draft status intentional? |
ashearin
requested review from
justaugustus and
raghavkaul
and removed request for
a team
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Can we add a test for this |
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
approved these changes
Jan 4, 2024
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
…rd-gitlab into no-commits-bug
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Simple length check on raw commit array prior to attempting to access the first index
What is the current behavior?
It's assumed that the repository will return commits, sets the first element as the 'before' time for future processing.
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Fixes #3727
Related to #3193
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)