Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 fixup transposition typos in remediation package copy #3734

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

daveworth
Copy link
Contributor

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

Small typos in comments in the remediation package.

What is the new behavior (if this is a feature change)?**

Those small typos in comments in the remediation package have been corrected.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

NONE

Does this PR introduce a user-facing change?

Generated docs will have fewer typos in the remediation package.

NONE

@daveworth daveworth requested a review from a team as a code owner December 13, 2023 17:04
@daveworth daveworth requested review from justaugustus and spencerschrock and removed request for a team December 13, 2023 17:05
@justaugustus justaugustus enabled auto-merge (squash) December 13, 2023 17:26
@justaugustus justaugustus changed the title 📖 / 🐛 fixup transposition typos in remediation package 📖 fixup transposition typos in remediation package copy Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #3734 (1862447) into main (d5900ed) will decrease coverage by 9.44%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3734      +/-   ##
==========================================
- Coverage   76.08%   66.65%   -9.44%     
==========================================
  Files         216      216              
  Lines       14963    14963              
==========================================
- Hits        11385     9973    -1412     
- Misses       2892     4414    +1522     
+ Partials      686      576     -110     

@spencerschrock
Copy link
Member

@daveworth you'll need to DCO your original commit

Full context at:
https://github.com/ossf/scorecard/pull/3734/checks?check_run_id=19609234863

Depending on if you pulled Stephen's merge commit down, the instructions there will probably need to be modified.

If you didnt:

git rebase HEAD~1 --signoff
git push --force origin cleanup/dave/typos

auto-merge was automatically disabled December 13, 2023 21:01

Head branch was pushed to by a user without write access

Signed-off-by: Dave Worth <dave@ensignia.co>
@daveworth
Copy link
Contributor Author

@spencerschrock - got it - thanks! I am green now. I apologize for the missed step.

@spencerschrock spencerschrock merged commit f4bf574 into ossf:main Dec 18, 2023
38 checks passed
@daveworth daveworth deleted the cleanup/dave/typos branch December 21, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants