🌱 fix rangeValCopy linter issues #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the Required field to PullRequestReviewRule made BranchRef slightly too big for the linter. This code isn't highly used, so just ignoring the inefficiency for now. Not sure why the staticcheck linter started complaining about the date error checking, but fixed it while I was here. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
raghavkaul and
laurentsimon
and removed request for
a team
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3735 +/- ##
==========================================
- Coverage 68.96% 68.80% -0.16%
==========================================
Files 216 216
Lines 14962 14963 +1
==========================================
- Hits 10318 10295 -23
- Misses 4022 4053 +31
+ Partials 622 615 -7 |
raghavkaul
approved these changes
Dec 13, 2023
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Required field to PullRequestReviewRule in #3728 made BranchRef slightly too big (>128 bytes) for the linter's
rangeValCopyrule. This code isn't highly used, so just ignoring any potential inefficiency.Not sure why the
staticchecklinter started complaining about the date error checking, but fixed it while I was here.What kind of change does this PR introduce?
linter fix
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)