🐛 Fix signed release error for empty gitlab repo

checks/evaluation/signed_releases.go

@@ -15,6 +15,7 @@
 package evaluation
 
 import (
+	"errors"
 	"fmt"
 	"math"
 
@@ -25,6 +26,8 @@
 	"github.com/ossf/scorecard/v4/probes/releasesHaveProvenance"
 )
 
+var errNoReleaseFound = errors.New("no release found")
+
 // SignedReleases applies the score policy for the Signed-Releases check.
 func SignedReleases(name string,
 	findings []finding.Finding, dl checker.DetailLogger,
@@ -47,11 +50,16 @@
 		f := &findings[i]
 
 		// Debug release name
-		releaseName, err := getReleaseName(f)
-		if err != nil {
-			e := sce.WithMessage(sce.ErrScorecardInternal, "could not get release name")
-			return checker.CreateRuntimeErrorResult(name, e)
+		if f.Outcome == finding.OutcomeNotApplicable {
+			// Generic summary.
+			return checker.CreateInconclusiveResult(name, "no releases found")
 		}
+		releaseName := getReleaseName(f)
+		if releaseName == "" {
+			// Generic summary.
+			return checker.CreateRuntimeErrorResult(name, errNoReleaseFound)
+		}
+
 		if !contains(loggedReleases, releaseName) {
 			dl.Debug(&checker.LogMessage{
 				Text: fmt.Sprintf("GitHub release found: %s", releaseName),
@@ -60,13 +68,6 @@
 		}
 
 		// Check if outcome is NotApplicable
-		if f.Outcome == finding.OutcomeNotApplicable {
-			dl.Warn(&checker.LogMessage{
-				Text: "no GitHub releases found",
-			})
-			// Generic summary.
-			return checker.CreateInconclusiveResult(name, "no releases found")
-		}
 	}
 
 	totalPositive := 0
@@ -77,11 +78,10 @@
 	for i := range findings {
 		f := &findings[i]
 
-		releaseName, err := getReleaseName(f)
-		if err != nil {
-			return checker.CreateRuntimeErrorResult(name, err)
+		releaseName := getReleaseName(f)
+		if releaseName == "" {
+			return checker.CreateRuntimeErrorResult(name, errNoReleaseFound)
 		}
-
 		if !contains(uniqueReleaseTags, releaseName) {
 			uniqueReleaseTags = append(uniqueReleaseTags, releaseName)
 		}
@@ -126,7 +126,7 @@
 	return checker.CreateResultWithScore(name, reason, score)
 }
 
-func getReleaseName(f *finding.Finding) (string, error) {
+func getReleaseName(f *finding.Finding) string {
 	m := f.Values
 	for k, v := range m {
 		var value int
@@ -137,10 +137,10 @@
 			value = int(releasesHaveProvenance.ValueTypeRelease)
 		}
 		if v == value {
-			return k, nil
+			return k
 		}
 	}
-	return "", sce.WithMessage(sce.ErrScorecardInternal, "could not get release tag")
+	return ""
 }
 
 func contains(releases []string, release string) bool {

checks/evaluation/signed_releases_test.go

@@ -38,12 +38,6 @@ const (
 	asset1 = 1
 	asset2 = 2
 	asset3 = 3
-	asset4 = 4
-	asset5 = 5
-	asset6 = 6
-	asset7 = 7
-	asset8 = 8
-	asset9 = 9
 )
 
 func signedProbe(release, asset int, outcome finding.Outcome) finding.Finding {
@@ -282,3 +276,59 @@ func TestSignedReleases(t *testing.T) {
 		})
 	}
 }
+
+func Test_getReleaseName(t *testing.T) {
+	t.Parallel()
+	type args struct {
+		f *finding.Finding
+	}
+	tests := []struct {
+		name string
+		args args
+		want string
+	}{
+		{
+			name: "no release",
+			args: args{
+				f: &finding.Finding{
+					Values: map[string]int{},
+				},
+			},
+			want: "",
+		},
+		{
+			name: "release",
+			args: args{
+				f: &finding.Finding{
+					Values: map[string]int{
+						"v1": int(releasesAreSigned.ValueTypeRelease),
+					},
+					Probe: releasesAreSigned.Probe,
+				},
+			},
+			want: "v1",
+		},
+		{
+			name: "release and asset",
+			args: args{
+				f: &finding.Finding{
+					Values: map[string]int{
+						"v1":         int(releasesAreSigned.ValueTypeRelease),
+						"artifact-1": int(releasesAreSigned.ValueTypeReleaseAsset),
+					},
+					Probe: releasesAreSigned.Probe,
+				},
+			},
+			want: "v1",
+		},
+	}
+	for _, tt := range tests {
+		tt := tt
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+			if got := getReleaseName(tt.args.f); got != tt.want {
+				t.Errorf("getReleaseName() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}