Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Dependency-Update-Tool: ignore search commit data for repo clients which dont support it #3756

Merged

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

bug fix

What is the current behavior?

Repos which dont have any dependency update tool config files fallback to searching for dependabot commits. For local repos, this search isn't supported and results in an error

What is the new behavior (if this is a feature change)?**

The primary data is the configuration files and the search commit data is just extra, so better to return some data than no data in this case.

We can eventually add the commit searching for local repos via #1709.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #2985

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

The primary data is the configuration files and the search commit data
is just extra, so better to return some data than no data in this case.

Signed-off-by: Spencer Schrock <sschrock@google.com>
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Merging #3756 (722e606) into main (9b5de80) will decrease coverage by 7.02%.
The diff coverage is 85.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3756      +/-   ##
==========================================
- Coverage   75.94%   68.93%   -7.02%     
==========================================
  Files         227      227              
  Lines       15351    15356       +5     
==========================================
- Hits        11658    10585    -1073     
- Misses       2974     4125    +1151     
+ Partials      719      646      -73     

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@spencerschrock spencerschrock enabled auto-merge (squash) December 29, 2023 17:38
@spencerschrock spencerschrock merged commit 69bb742 into ossf:main Dec 29, 2023
38 checks passed
@spencerschrock spencerschrock deleted the fix/dut-local-no-dependabot-config branch December 29, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: unsupported feature
2 participants