🐛 ensure Signed-Releases only scores 5 releases #3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
naveensrinivasan and
laurentsimon
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3768 +/- ##
==========================================
- Coverage 75.91% 70.89% -5.02%
==========================================
Files 229 229
Lines 15372 15377 +5
==========================================
- Hits 11669 10901 -768
- Misses 2980 3807 +827
+ Partials 723 669 -54 |
laurentsimon
approved these changes
Jan 3, 2024
|
/scdiff generate Signed-Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
the
releasesHaveProvenancewas creating too many findings for repos which had more than 5 releases with provenance, which violated an assumption of theSigned-Releasesevaluation codeWhat is the new behavior (if this is a feature change)?**
the
releasesHaveProvenanceprobe only generates 5 releases, and a consistency check was added to the evaluation codeWhich issue(s) this PR fixes
Fixes #3766
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)