🐛 Handle osvscanner errors on projects with no dependencies #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
justaugustus and
laurentsimon
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3803 +/- ##
==========================================
- Coverage 75.48% 68.72% -6.77%
==========================================
Files 230 230
Lines 15622 15624 +2
==========================================
- Hits 11793 10737 -1056
- Misses 3103 4231 +1128
+ Partials 726 656 -70 |
spencerschrock
commented
Jan 17, 2024
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
laurentsimon
approved these changes
Jan 19, 2024
|
/scdiff generate Vulnerabilities |
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
osvscanner.DoScanthrows an error when no packages are found. This bubbles up to theVulnerabilitiescheck as a runtime error.What is the new behavior (if this is a feature change)?**
We ignore
osvscanner.NoPackagesFoundErr.Which issue(s) this PR fixes
Fixes #3802
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)