🌱 polish scorecard workflow for use as example workflow #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the version comments, adds some explanatory comments, and generally makes it better. The intent is to use this file as an example for the Scorecard Action repo so it remains up-to-date. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
naveensrinivasan and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3969 +/- ##
==========================================
- Coverage 75.01% 70.52% -4.49%
==========================================
Files 227 227
Lines 16263 16263
==========================================
- Hits 12199 11469 -730
- Misses 3290 4067 +777
+ Partials 774 727 -47 |
laurentsimon
approved these changes
Mar 22, 2024
2 tasks
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
This updates the version comments, adds some explanatory comments, and generally makes it better. The intent is to use this file as an example for the Scorecard Action repo so it remains up-to-date. Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
workflow update
What is the current behavior?
Some version comments are out of date.
One actions is out of date
What is the new behavior (if this is a feature change)?**
repo_tokenarg since it will use the GitHub token by default anywaygithub/codeql-action/upload-sarifto the latest release, not sure why dependabot hasn't updated it.The intent is to use this file as an example for the Scorecard Action repo (see ossf/scorecard-action#1352) so it remains up-to-date through dependabot. Currently the workflow example from the Scorecard Action readme is out of date (see #3968) .
Where possible I tried to make the workflow match our example, in terms of comments.
Which issue(s) this PR fixes
Related to #3968 and ossf/scorecard-action#1287
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)