Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ removerule.Remediation and switch users to probe.Remediation #3978

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

an old struct was left in the code

What is the new behavior (if this is a feature change)?**

probes were initially called rules, so deleted rule and switched usages to probe.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #3677

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

probes were initially called rules, so deleted rule and switched
usages to probe.

Signed-off-by: Spencer Schrock <sschrock@google.com>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #3978 (0e1f552) into main (153e06d) will decrease coverage by 4.56%.
The diff coverage is 71.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3978      +/-   ##
==========================================
- Coverage   75.03%   70.47%   -4.56%     
==========================================
  Files         226      225       -1     
  Lines       16147    16021     -126     
==========================================
- Hits        12116    11291     -825     
- Misses       3263     4014     +751     
+ Partials      768      716      -52     

@spencerschrock
Copy link
Member Author

/scdiff generate Pinned-Dependencies

Copy link

@spencerschrock spencerschrock marked this pull request as ready for review March 27, 2024 21:45
@spencerschrock spencerschrock requested a review from a team as a code owner March 27, 2024 21:45
@spencerschrock spencerschrock requested review from justaugustus and raghavkaul and removed request for a team March 27, 2024 21:45
@spencerschrock spencerschrock merged commit 775fc97 into ossf:main Apr 9, 2024
36 checks passed
@spencerschrock spencerschrock deleted the remove-rule branch April 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Merge probe Remediation and rule Remediation
2 participants