Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Review and update CONTRIBUTING.md #4002

Merged
merged 10 commits into from
Apr 4, 2024
Merged

📖 Review and update CONTRIBUTING.md #4002

merged 10 commits into from
Apr 4, 2024

Commits on Apr 3, 2024

  1. feature dco requirement more prominently 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    99c0e36 View commit details
    Browse the repository at this point in the history

  2. recommend merge commits to sync PR 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    b123cbd View commit details
    Browse the repository at this point in the history

  3. fix make target table 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    0ad51cd View commit details
    Browse the repository at this point in the history

  4. remove references to old Go environment variables 

    GO111MODULE is no longer used as of Go 1.17.
GOPATH is still used for other purposes, but not in 'development mode'.
https://go.dev/wiki/GOPATH

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    12867ac View commit details
    Browse the repository at this point in the history

  5. misc minor clarifications 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    be7a687 View commit details
    Browse the repository at this point in the history

  6. remove reference to errors from CONTRIBUTORS.md 

    I don't think this is one of the top things we should be displaying to someone

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5a2dc9e View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. mention make in environment 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b792ee1 View commit details
    Browse the repository at this point in the history

  2. no scopes needed for PATs 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e888c13 View commit details
    Browse the repository at this point in the history

  3. highlight other scorecard options 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    deacac2 View commit details
    Browse the repository at this point in the history

  4. allow shell codeblocks to be pasted into a shell 

    the comment style was wrong and the $ was interpretted as a command.

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0dca25e View commit details
    Browse the repository at this point in the history