Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 revert PAT scope change and document Go resources #4003

Merged

Conversation

spencerschrock
Copy link
Member

@spencerschrock spencerschrock commented Apr 4, 2024

What kind of change does this PR introduce?

docs.

reverts part of #4002. it turns out public_repo scope is needed for branch protection after all.

A few basic Go resources added for contributors unfamiliar with the language

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock requested review from a team, naveensrinivasan and raghavkaul and removed request for a team April 4, 2024 22:13
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #4003 (1b692dd) into main (b118c19) will increase coverage by 1.92%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4003      +/-   ##
==========================================
+ Coverage   66.70%   68.62%   +1.92%     
==========================================
  Files         223      223              
  Lines       16070    16070              
==========================================
+ Hits        10719    11028     +309     
+ Misses       4688     4342     -346     
- Partials      663      700      +37     

some contributors may be unfamiliar with the language

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock changed the title 📖 undo personal access token scope change 📖 revert PAT scope change and document Go resources Apr 5, 2024
@spencerschrock spencerschrock merged commit 4c6d0e5 into ossf:main Apr 8, 2024
42 checks passed
@spencerschrock spencerschrock deleted the contributor-public-repo-scope branch April 8, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants