Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix signed-releases lookback limit precedence #4060

Merged
merged 3 commits into from
May 2, 2024
Merged

🐛 fix signed-releases lookback limit precedence #4060

merged 3 commits into from
May 2, 2024

Commits on Apr 29, 2024

  1. switch signed-releases lookback limit precedence 

    if the 6th release had no assets, the lookback limit exit condition was
being skipped. This led to scenarios where too many releases were being
considered by the Signed-Releases check.

ossf#4059

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    9c722e1 View commit details
    Browse the repository at this point in the history

  2. make exit condition stronger 

    any release after the lookback should be skipped

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7d0faf3 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge branch 'main' into fix-signed-releases 

    Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2891a51 View commit details
    Browse the repository at this point in the history